Add pending task tracking to Guest for workload monitoring#4696
Draft
skycastlelily wants to merge 1 commit intomainfrom
Draft
Add pending task tracking to Guest for workload monitoring#4696skycastlelily wants to merge 1 commit intomainfrom
skycastlelily wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces pending task tracking on Guest objects, which is a valuable addition for workload monitoring and resource management. The implementation is thread-safe and handles task increments and decrements correctly, including in abort scenarios.
I've identified two areas for improvement in tmt/steps/execute/__init__.py to enhance code clarity and conciseness. One is simplifying a loop for finding a discover phase, and the other is removing a redundant condition check.
eb5d71b to
ccb14e1
Compare
…ed guests - Add is_released property to Guest class to safely check if guest was released early - Implement thread-safe guest release tracking in Provision step with _released_guests set - Skip push/pull operations on released guests to prevent errors - Skip cleanup and finish operations on released guests - Add @container decorators to PushTask and PullTask classes
ccb14e1 to
d814338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist