Skip to content

Add pending task tracking to Guest for workload monitoring#4696

Draft
skycastlelily wants to merge 1 commit intomainfrom
task-tracking
Draft

Add pending task tracking to Guest for workload monitoring#4696
skycastlelily wants to merge 1 commit intomainfrom
task-tracking

Conversation

@skycastlelily
Copy link
Copy Markdown
Collaborator

@skycastlelily skycastlelily commented Mar 13, 2026

   Add centralized guest release tracking and skip operations on released guests

  - Add is_released property to Guest class to safely check if guest was released early
  - Implement thread-safe guest release tracking in Provision step with _released_guests set
  - Skip push/pull operations on released guests to prevent errors
  - Skip cleanup and finish operations on released guests
  - Add @container decorators to PushTask and PullTask classes

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily marked this pull request as draft March 13, 2026 14:36
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces pending task tracking on Guest objects, which is a valuable addition for workload monitoring and resource management. The implementation is thread-safe and handles task increments and decrements correctly, including in abort scenarios.

I've identified two areas for improvement in tmt/steps/execute/__init__.py to enhance code clarity and conciseness. One is simplifying a loop for finding a discover phase, and the other is removing a redundant condition check.

…ed guests

  - Add is_released property to Guest class to safely check if guest was released early
  - Implement thread-safe guest release tracking in Provision step with _released_guests set
  - Skip push/pull operations on released guests to prevent errors
  - Skip cleanup and finish operations on released guests
  - Add @container decorators to PushTask and PullTask classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant