Skip to content

CHI-3641: Add channel_type attribute to new aselo webchat conversations.#4087

Draft
stephenhand wants to merge 6 commits intomasterfrom
CHI-3641-channel_type_convo_attribute
Draft

CHI-3641: Add channel_type attribute to new aselo webchat conversations.#4087
stephenhand wants to merge 6 commits intomasterfrom
CHI-3641-channel_type_convo_attribute

Conversation

@stephenhand
Copy link
Collaborator

Description

Also remove redundant proxy session check from conversations path of the channel janitor

Checklist

  • Corresponding issue has been opened
  • [n/a] New tests added
  • [n/a] Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • [n/a] Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand
Copy link
Collaborator Author

@copilot - add unit test coverage for the updated initWebchat.ts

client.flexApi.v2.webChannels.create and patchConversationAttributes are calls with side effects, explicitly check they are invoked

Copy link
Contributor

Copilot AI commented Mar 23, 2026

@stephenhand I've opened a new pull request, #4088, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants