Fix parsing error of the tag from buffered reader, when the first byte < is the last in the internal buffer of BufRead#940
Open
Mingun wants to merge 4 commits intotafia:masterfrom
Open
Fix parsing error of the tag from buffered reader, when the first byte < is the last in the internal buffer of BufRead#940Mingun wants to merge 4 commits intotafia:masterfrom
< is the last in the internal buffer of BufRead#940Mingun wants to merge 4 commits intotafia:masterfrom
Conversation
…have `<` in input Currently those methods are called when position points to `<` in XML source, so test them in that environment
failures:
issue939
…kup methods That is: - read_bang_element - read_element In next commit buffered readers will require to skip the first byte because it will be consumed in peek_one Slice reader does not require and cannot consume that byte
…e `<` is the last in the BufRead internal buffer
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 58.08% 55.00% -3.09%
==========================================
Files 42 44 +2
Lines 15513 16816 +1303
==========================================
+ Hits 9011 9249 +238
- Misses 6502 7567 +1065
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dralley
reviewed
Feb 17, 2026
|
|
||
| /// Regression test for https://github.com/tafia/quick-xml/issues/939 | ||
| #[test] | ||
| fn issue939() { |
Collaborator
There was a problem hiding this comment.
It would be nice if these would have a short note on what was being tested, apart from the issue number. But given that's the current pattern for this file, this isn't a blocking request.
dralley
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #939 which is regression from #936