Fix #597: Pop namespace scope after NsReader::read_to_end#598
Merged
Mingun merged 4 commits intotafia:masterfrom Feb 15, 2026
Merged
Fix #597: Pop namespace scope after NsReader::read_to_end#598Mingun merged 4 commits intotafia:masterfrom
Mingun merged 4 commits intotafia:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 58.08% 54.99% -3.09%
==========================================
Files 42 44 +2
Lines 15513 16817 +1304
==========================================
+ Hits 9011 9249 +238
- Misses 6502 7568 +1066
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
failures (25):
reader-namespaces.rs (24):
read_text::cdata
read_text::comment
read_text::decl
read_text::doctype
read_text::empty
read_text::general_ref
read_text::pi
read_text::text
read_to_end::cdata
read_to_end::comment
read_to_end::decl
read_to_end::doctype
read_to_end::empty
read_to_end::general_ref
read_to_end::pi
read_to_end::text
read_to_end_into::cdata
read_to_end_into::comment
read_to_end_into::decl
read_to_end_into::doctype
read_to_end_into::empty
read_to_end_into::general_ref
read_to_end_into::pi
read_to_end_into::text
issues.rs (1)
issue597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to check that the changes does not break anything else when
read_to_endwould be called after each possible returned events, but now I'm too lazy to finish the tests. Will do that on weekend.