Skip to content

Add TIME_NS column support to DuckDB::Result #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suketa merged 3 commits into from
Apr 4, 2026
Merged

Add TIME_NS column support to DuckDB::Result #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1903178
Add TIME_NS column support to DuckDB::Result
suketa Apr 4, 2026
9a0784f
Skip TIME_NS tests on DuckDB < 1.5.0
suketa Apr 4, 2026
8feddfe
Fix NoMethodError: use ::DuckDBTest to reference top-level module
suketa Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.

# Unreleased

- add `TIME_NS` column support to `DuckDB::Result`. `TIME_NS` values are returned as `Time` objects with nanoseconds truncated to microseconds.

# 1.5.1.1 - 2026-04-04

- fix `DuckDB::ScalarFunction` to allow `HUGEINT` and `UHUGEINT` as `return_type` and parameter type (the C extension's vector write path was missing those cases).
Expand Down
2 changes: 2 additions & 0 deletions ext/duckdb/converter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ extern ID id__to_uuid_from_uhugeint;
extern ID id__to_time_from_duckdb_timestamp_s;
extern ID id__to_time_from_duckdb_timestamp_ms;
extern ID id__to_time_from_duckdb_timestamp_ns;
extern ID id__to_time_from_duckdb_time_ns;
extern ID id__to_time_from_duckdb_time_tz;
extern ID id__to_time_from_duckdb_timestamp_tz;
extern ID id__to_infinity;
Expand All @@ -24,6 +25,7 @@ VALUE rbduckdb_uhugeint_to_ruby(duckdb_uhugeint h);
VALUE rbduckdb_timestamp_s_to_ruby(duckdb_timestamp_s ts);
VALUE rbduckdb_timestamp_ms_to_ruby(duckdb_timestamp_ms ts);
VALUE rbduckdb_timestamp_ns_to_ruby(duckdb_timestamp_ns ts);
VALUE rbduckdb_time_ns_to_ruby(duckdb_time_ns ts);
VALUE rbduckdb_time_tz_to_ruby(duckdb_time_tz tz);
VALUE rbduckdb_timestamp_tz_to_ruby(duckdb_timestamp ts);
VALUE rbduckdb_time_to_ruby(duckdb_time t);
Expand Down
8 changes: 8 additions & 0 deletions ext/duckdb/conveter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ID id__to_uuid_from_uhugeint;
ID id__to_time_from_duckdb_timestamp_s;
ID id__to_time_from_duckdb_timestamp_ms;
ID id__to_time_from_duckdb_timestamp_ns;
ID id__to_time_from_duckdb_time_ns;
ID id__to_time_from_duckdb_time_tz;
ID id__to_time_from_duckdb_timestamp_tz;
ID id__to_infinity;
Expand Down Expand Up @@ -128,6 +129,12 @@ VALUE rbduckdb_timestamp_ns_to_ruby(duckdb_timestamp_ns ts) {
);
}

VALUE rbduckdb_time_ns_to_ruby(duckdb_time_ns ts) {
return rb_funcall(mDuckDBConverter, id__to_time_from_duckdb_time_ns, 1,
LL2NUM(ts.nanos)
);
}

VALUE rbduckdb_time_tz_to_ruby(duckdb_time_tz tz) {
duckdb_time_tz_struct data = duckdb_from_time_tz(tz);
return rb_funcall(mDuckDBConverter, id__to_time_from_duckdb_time_tz, 5,
Expand Down Expand Up @@ -201,6 +208,7 @@ void rbduckdb_init_duckdb_converter(void) {
id__to_time_from_duckdb_timestamp_s = rb_intern("_to_time_from_duckdb_timestamp_s");
id__to_time_from_duckdb_timestamp_ms = rb_intern("_to_time_from_duckdb_timestamp_ms");
id__to_time_from_duckdb_timestamp_ns = rb_intern("_to_time_from_duckdb_timestamp_ns");
id__to_time_from_duckdb_time_ns = rb_intern("_to_time_from_duckdb_time_ns");
id__to_time_from_duckdb_time_tz = rb_intern("_to_time_from_duckdb_time_tz");
id__to_time_from_duckdb_timestamp_tz = rb_intern("_to_time_from_duckdb_timestamp_tz");
id__to_infinity = rb_intern("_to_infinity");
Expand Down
8 changes: 8 additions & 0 deletions ext/duckdb/result.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ static VALUE vector_decimal(duckdb_logical_type ty, void* vector_data, idx_t row
static VALUE vector_timestamp_s(void* vector_data, idx_t row_idx);
static VALUE vector_timestamp_ms(void* vector_data, idx_t row_idx);
static VALUE vector_timestamp_ns(void* vector_data, idx_t row_idx);
static VALUE vector_time_ns(void* vector_data, idx_t row_idx);
static VALUE vector_enum(duckdb_logical_type ty, void* vector_data, idx_t row_idx);
static VALUE vector_array(duckdb_logical_type ty, duckdb_vector vector, idx_t row_idx);
static VALUE vector_list(duckdb_logical_type ty, duckdb_vector vector, void* vector_data, idx_t row_idx);
Expand Down Expand Up @@ -370,6 +371,10 @@ static VALUE vector_timestamp_ns(void* vector_data, idx_t row_idx) {
return rbduckdb_timestamp_ns_to_ruby(((duckdb_timestamp_ns *)vector_data)[row_idx]);
}

static VALUE vector_time_ns(void* vector_data, idx_t row_idx) {
return rbduckdb_time_ns_to_ruby(((duckdb_time_ns *)vector_data)[row_idx]);
}

static VALUE vector_enum(duckdb_logical_type ty, void* vector_data, idx_t row_idx) {
duckdb_type type = duckdb_enum_internal_type(ty);
uint8_t index;
Expand Down Expand Up @@ -498,6 +503,9 @@ VALUE rbduckdb_vector_value_at(duckdb_vector vector, duckdb_logical_type element
case DUCKDB_TYPE_TIMESTAMP_NS:
obj = vector_timestamp_ns(vector_data, index);
break;
case DUCKDB_TYPE_TIME_NS:
obj = vector_time_ns(vector_data, index);
break;
case DUCKDB_TYPE_ENUM:
obj = vector_enum(element_type, vector_data, index);
break;
Expand Down
3 changes: 3 additions & 0 deletions ext/duckdb/value_impl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ VALUE rbduckdb_duckdb_value_to_ruby(duckdb_value val) {
case DUCKDB_TYPE_TIMESTAMP_NS:
result = rbduckdb_timestamp_ns_to_ruby(duckdb_get_timestamp_ns(val));
break;
case DUCKDB_TYPE_TIME_NS:
result = rbduckdb_time_ns_to_ruby(duckdb_get_time_ns(val));
break;
case DUCKDB_TYPE_TIME_TZ:
result = rbduckdb_time_tz_to_ruby(duckdb_get_time_tz(val));
break;
Expand Down
10 changes: 10 additions & 0 deletions lib/duckdb/converter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,16 @@ def _to_time_from_duckdb_timestamp_ns(time)
end
end

def _to_time_from_duckdb_time_ns(nanos)
hour = nanos / 3_600_000_000_000
nanos %= 3_600_000_000_000
min = nanos / 60_000_000_000
nanos %= 60_000_000_000
sec = nanos / 1_000_000_000
microsecond = (nanos % 1_000_000_000) / 1_000
_to_time_from_duckdb_time(hour, min, sec, microsecond)
end

def _to_time_from_duckdb_time_tz(hour, min, sec, micro, timezone)
tz_offset = format_timezone_offset(timezone)
time_str = format('%<hour>02d:%<min>02d:%<sec>02d.%<micro>06d%<tz>s',
Expand Down
16 changes: 15 additions & 1 deletion test/duckdb_test/result_each_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ def teardown
# rubocop:disable Style/NumericLiterals, Layout/ExtraSpacing
# rubocop:disable Layout/SpaceInsideHashLiteralBraces, Layout/SpaceAfterComma
# rubocop:disable Style/TrailingCommaInArrayLiteral
# Minimum DuckDB library version required for each type.
MINIMUM_DUCKDB_VERSION = {
'TIME_NS' => '1.5.0'
}.freeze

TEST_TABLES = [
# DB Type , DB declartion String Rep Ruby Type Ruby Value
[:ok, 'BOOLEAN', 'BOOLEAN', 'true', TrueClass, true ],
Expand Down Expand Up @@ -107,6 +112,7 @@ def teardown
# set TIMEZONE to Asia/Kabul to test TIMETZ and TIMESTAMPTZ
[:ok, 'TIMETZ', 'TIMETZ', "'2019-11-03 12:34:56.123456789'", Time, timetz_expected ],
[:ok, 'TIMESTAMPTZ', 'TIMESTAMPTZ', "'2019-11-03 12:34:56.123456789'", Time, Time.parse('2019-11-03 08:04:56.123456+0000') ],
[:ok, 'TIME_NS', 'TIME_NS', "'12:34:56.789123456'", Time, Time.parse('12:34:56.789123') ],
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if TIME_NS is a recognized DuckDB type and how it should be used
rg -n 'TIME_NS' --type=c ext/duckdb/

# Check similar test patterns for other time types
rg -n "TIMESTAMP_NS|TIME_TZ" test/duckdb_test/result_each_test.rb -A2 -B2

# Look for how TIME_NS is documented/used elsewhere
rg -n 'time_ns|TIME_NS' lib/ ext/

Repository: suketa/ruby-duckdb

Length of output: 2652

🏁 Script executed:

sed -n '70,90p' lib/duckdb/converter.rb

Repository: suketa/ruby-duckdb

Length of output: 777

🏁 Script executed:

sed -n '130,145p' ext/duckdb/conveter.c

Repository: suketa/ruby-duckdb

Length of output: 676

🏁 Script executed:

grep -n "time_ns\|TIME_NS" lib/duckdb/converter.rb -B2 -A5

Repository: suketa/ruby-duckdb

Length of output: 309

🏁 Script executed:

grep -n "_to_time_from_duckdb_time" lib/duckdb/converter.rb -A3

Repository: suketa/ruby-duckdb

Length of output: 1621

🏁 Script executed:

sed -n '140,150p' test/duckdb_test/result_each_test.rb

Repository: suketa/ruby-duckdb

Length of output: 476

🏁 Script executed:

grep -n "TIME_NS\|time_ns" ext/extconf.rb ext/duckdb.h 2>/dev/null || grep -rn "DuckDB.*1\." ext/extconf.rb 2>/dev/null | head -20

Repository: suketa/ruby-duckdb

Length of output: 44

🏁 Script executed:

# Check if there are any version checks or conditionals around TIME_NS
grep -rn "TIME_NS" ext/duckdb/ --type=c -B3 -A3 | head -40

# Check DuckDB C library version constants
fd -e h -e c ext/duckdb | xargs grep -l "DUCKDB_VERSION\|DUCKDB_TYPE_TIME"

Repository: suketa/ruby-duckdb

Length of output: 529

🏁 Script executed:

# Check if there's a .duckdb.so or compiled extension
find ext -name "*.so" -o -name "*.h" | grep -E "(version|duckdb\.h)" | head -5

# Search for any version-gated code or TIME_NS conditionals
rg "VERSION|TIME_NS" ext/ --type=c --type=h -i | grep -E "(if|define)" | head -20

Repository: suketa/ruby-duckdb

Length of output: 195

🏁 Script executed:

# Check DuckDB header for type definitions
cat ext/duckdb/ruby-duckdb.h | grep -i "time_ns\|version" | head -20

# Look for the actual duckdb version being used
rg "duckdb.*version" ext/ lib/ -i -A2 -B2

# Check when TIME_NS was introduced in DuckDB - look at comments or documentation
rg "TIME_NS|type.*39" ext/duckdb/ -A2 -B2

Repository: suketa/ruby-duckdb

Length of output: 3946

🏁 Script executed:

# Find the query generation logic in the test
sed -n '1,50p' test/duckdb_test/result_each_test.rb

# Look for the query building logic
rg -n "insert into\|CREATE TABLE\|def.*query" test/duckdb_test/result_each_test.rb -i -B2 -A2 | head -40

Repository: suketa/ruby-duckdb

Length of output: 4720

🏁 Script executed:

# Check git log for the TIME_NS addition
git log -p --all -- test/duckdb_test/result_each_test.rb | grep -A5 -B5 "TIME_NS" | head -50

Repository: suketa/ruby-duckdb

Length of output: 44

🏁 Script executed:

# Find the exact TIME_NS entry and surrounding context
sed -n '100,125p' test/duckdb_test/result_each_test.rb

# Find where queries are executed
rg -n "def test_\|execute\|TEST_TABLES\[" test/duckdb_test/result_each_test.rb | head -20

# Look at how the test iterates through TEST_TABLES
sed -n '150,200p' test/duckdb_test/result_each_test.rb

Repository: suketa/ruby-duckdb

Length of output: 4189

🏁 Script executed:

# Check what happens with BIT which uses explicit casting
sed -n '115,120p' test/duckdb_test/result_each_test.rb

# Search for other types that use explicit casting in the test data
rg "::BIT|::TIME|CAST" test/duckdb_test/result_each_test.rb

Repository: suketa/ruby-duckdb

Length of output: 922

🏁 Script executed:

# Check if there are any recent commits that added TIME_NS
git log --oneline --all -- test/duckdb_test/result_each_test.rb | head -10

# Look for any TODOs or FIXMEs related to TIME_NS
rg "TODO|FIXME|TIME_NS" test/ lib/ ext/ -i

Repository: suketa/ruby-duckdb

Length of output: 2393

🏁 Script executed:

# Show the full commit that added TIME_NS support
git show 1903178 --stat

# Also check if there are any other TIME_NS tests or examples in the codebase
rg "TIME_NS" . --type=rb --type=c -B3 -A3 | grep -E "(test_|def |TIME_NS)" | head -30

Repository: suketa/ruby-duckdb

Length of output: 11518

🏁 Script executed:

# Check if there's any documentation or comments about TIME_NS syntax in DuckDB
rg "TIME_NS|time_ns" ext/duckdb/ -B5 -A5 | grep -E "(comment|TODO|//|/\*)" | head -20

# Check if there's a way to cast to TIME_NS
rg "CAST.*TIME" test/ lib/ -i | head -10

Repository: suketa/ruby-duckdb

Length of output: 835

🏁 Script executed:

# Look for the result_time_ns_test.rb file
find test -name "*time_ns*" -o -name "*TIME_NS*"

# If it exists, show its contents
cat test/duckdb_test/result_time_ns_test.rb 2>/dev/null || echo "File not found"

Repository: suketa/ruby-duckdb

Length of output: 76

🏁 Script executed:

# Search for TIME test patterns to see if there's a difference
rg -n "result_time.*test|TIME.*test" test/duckdb_test/ | grep -v result_each_test

# Look for the actual TIME entry in TEST_TABLES to compare with TIME_NS
sed -n '50,60p' test/duckdb_test/result_each_test.rb

Repository: suketa/ruby-duckdb

Length of output: 2045

🏁 Script executed:

# Check if result_time_ns_test.rb exists
ls -la test/duckdb_test/result_time_ns_test.rb 2>&1

# List all test files to see what exists
ls test/duckdb_test/*time* 2>/dev/null || echo "No time-related test files found"

# Check git status to see if the file was supposed to be there
git log --name-status --oneline 1903178 | head -30

Repository: suketa/ruby-duckdb

Length of output: 1036

🏁 Script executed:

# Check for recent commits after TIME_NS support was added
git log --oneline --all | head -20

# Check if there are any skipped tests related to TIME_NS
rg "skip.*TIME_NS|TIME_NS.*skip" test/

Repository: suketa/ruby-duckdb

Length of output: 1382

🏁 Script executed:

# Check if there are any comments or documentation about TIME_NS syntax
rg "TIME_NS|time_ns" . --type=md --type=txt 2>/dev/null | head -20

# Check if BIT uses explicit casting and if TIME_NS should too
rg "::BIT|::TIME|CAST.*TIME" test/duckdb_test/ -B2 -A2 | head -40

# Look at how result_time_tz_test.rb handles TIMETZ to see if TIME_NS needs similar setup
cat test/duckdb_test/result_time_tz_test.rb

Repository: suketa/ruby-duckdb

Length of output: 3743

🏁 Script executed:

# Check if TIME_NS needs special setup like ICU like TIMETZ does
rg "INSTALL|LOAD" test/duckdb_test/result_time_tz_test.rb

# Check if the prepare_test_table_and_data function has any special handling we missed
sed -n '117,135p' test/duckdb_test/result_each_test.rb

# Check if TIME_NS might need explicit casting like BIT does
rg -A30 "def prepare_test_table_and_data" test/duckdb_test/result_each_test.rb | head -40

Repository: suketa/ruby-duckdb

Length of output: 2276

🏁 Script executed:

# Compare how TIME and TIME_NS values are being parsed in the INSERT statement
rg "TIME.*'[0-9:]" test/duckdb_test/result_each_test.rb | grep -E "(TIME_NS|'TIME'|TIME[^_Z])"

# Check if we should be using CAST for TIME_NS
git show 1903178:test/duckdb_test/result_each_test.rb | grep -A2 -B2 "TIME_NS"

Repository: suketa/ruby-duckdb

Length of output: 2727

🏁 Script executed:

# Count how many TIME_NS entries exist in the current file
grep -n "TIME_NS" test/duckdb_test/result_each_test.rb | wc -l

# Show all TIME_NS entries with context
grep -n "TIME_NS" test/duckdb_test/result_each_test.rb -B1 -A1

# Check if this might be a syntax issue - does TIME_NS need explicit casting like BIT?
# Let me check if DuckDB documentation says TIME_NS needs casting
rg "::TIME|CAST.*TIME" test/ -i | head -10

Repository: suketa/ruby-duckdb

Length of output: 1609

🏁 Script executed:

# Check if there's any example of TIME_NS being used with CAST
git log --all -p | grep -A5 -B5 "TIME_NS.*CAST\|CAST.*TIME_NS" | head -20

# Search for any workarounds or issues related to TIME_NS literal parsing
rg "TIME_NS" . -i | grep -E "(TODO|FIXME|BUG|issue|workaround)"

Repository: suketa/ruby-duckdb

Length of output: 148

🏁 Script executed:

# Check if adding explicit casting would work by looking at similar patterns
# First, let's see what happens if we look at how the INSERT query would look

echo "Current TIME_NS test:"
echo "INSERT INTO tests VALUES ( '12:34:56.789123456' )"
echo ""
echo "Likely fix - with explicit casting:"
echo "INSERT INTO tests VALUES ( '12:34:56.789123456'::TIME_NS )"
echo ""

# Verify that BIT uses explicit casting and TIME doesn't
grep -E "BIT|'TIME'" test/duckdb_test/result_each_test.rb | grep -E "(::|\[')" | head -5

Repository: suketa/ruby-duckdb

Length of output: 950

Add explicit casting to TIME_NS literal in test data.

The TIME_NS test fails with NoMethodError: undefined method 'hour' for nil because the INSERT statement cannot parse the TIME_NS literal. Precision-dependent types like BIT require explicit casting (e.g., '010110'::BIT), and TIME_NS follows the same pattern.

Update line 110 in test/duckdb_test/result_each_test.rb to add explicit casting:

From:

[:ok, 'TIME_NS',      'TIME_NS',                      "'12:34:56.789123456'",                    Time,                 Time.parse('12:34:56.789123')                       ],

To:

[:ok, 'TIME_NS',      'TIME_NS',                      "'12:34:56.789123456'::TIME_NS",           Time,                 Time.parse('12:34:56.789123')                       ],

Without the casting, DuckDB returns NULL for the TIME_NS column, causing the nil error when the test tries to access time properties.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@test/duckdb_test/result_each_test.rb` at line 110, The TIME_NS test row is
inserting the literal "'12:34:56.789123456'" without an explicit type cast,
causing DuckDB to return NULL and later a NoMethodError when Time methods are
called; update the test data row where the column/type is 'TIME_NS' to cast the
literal to TIME_NS (change the literal to include ::TIME_NS) so the INSERT
parses the nanosecond-precision time correctly—look for the array entry
containing 'TIME_NS' in result_each_test.rb and modify the third value in that
tuple to "'12:34:56.789123456'::TIME_NS".

].freeze
# rubocop:enable Layout/LineLength, Layout/SpaceInsideArrayLiteralBrackets
# rubocop:enable Style/NumericLiterals, Layout/ExtraSpacing
Expand Down Expand Up @@ -141,7 +147,7 @@ def async_query_test_data
end

def do_query_result_assertions(res, ruby_val, db_type, klass)
if %w[TIME TIMETZ].include?(db_type)
if %w[TIME TIMETZ TIME_NS].include?(db_type)
assert_equal(
[ruby_val.hour, ruby_val.min, ruby_val.sec, ruby_val.usec, ruby_val.utc_offset],
[res.hour, res.min, res.sec, res.usec, res.utc_offset]
Expand All @@ -157,6 +163,10 @@ def do_query_result_assertions(res, ruby_val, db_type, klass)
do_test, db_type, db_declaration, string_rep, klass, ruby_val = *spec
define_method :"test_#{db_type}_type#{i}" do
skip spec.to_s if do_test == :ng
min_ver = MINIMUM_DUCKDB_VERSION[db_type]
if min_ver && ::DuckDBTest.duckdb_library_version < Gem::Version.new(min_ver)
skip "#{db_type} requires DuckDB >= #{min_ver}"
end

prepare_test_table_and_data(db_declaration, db_type, string_rep)

Expand All @@ -167,6 +177,10 @@ def do_query_result_assertions(res, ruby_val, db_type, klass)

define_method :"test_stream_#{db_type}_type#{i}" do
skip spec.to_s if do_test == :ng
min_ver = MINIMUM_DUCKDB_VERSION[db_type]
if min_ver && ::DuckDBTest.duckdb_library_version < Gem::Version.new(min_ver)
skip "#{db_type} requires DuckDB >= #{min_ver}"
end

prepare_test_table_and_data(db_declaration, db_type, string_rep)

Expand Down
Loading