Open
Conversation
Contributor
mbwhite
commented
Mar 13, 2026
mbwhite
commented
- use new api for create catalog reader
- remove the helper class
- Derby is no longer supported
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mbwhite
force-pushed
the
update-sql-examples
branch
from
50d733e to
c7f1047
Compare
mbwhite
changed the title
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday,
nielspardon and
vbarua
Member
|
can you also add it in the list of examples of the repo root readme? just noticed it is missing there |
nielspardon
reviewed
Mar 16, 2026
Contributor
Author
Yes - updated and rebased ... thanks. |
mbwhite
force-pushed
the
update-sql-examples
branch
from
6cf658d to
746f592
Compare
nielspardon
reviewed
Mar 16, 2026
examples/isthmus-api/src/main/java/io/substrait/examples/FromSql.java
Outdated
Show resolved
Hide resolved
mbwhite
force-pushed
the
update-sql-examples
branch
2 times, most recently
from
f6d6414 to
f78cf69
Compare
nielspardon
reviewed
Mar 16, 2026
- use new api for create catalog reader - remove the helper class - Derby is no longer supported Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
update-sql-examples
branch
from
7216b28 to
34e0494
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
update-sql-examples
branch
from
34e0494 to
dde5227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.