fix(core): use new aggregate grouping behavior in RelProtoConverter#744
fix(core): use new aggregate grouping behavior in RelProtoConverter#744nielspardon merged 5 commits intosubstrait-io:mainfrom
Conversation
|
Thanks for doing this! Will review when I have a free moment, but I think this would qualify as a breaking change, so it will need the |
885f9db to
5d96001
Compare
|
I think we will want to have a discussion about this one at the community sync. The way I see it there are two ways forwards:
I'm not sure what the right approach is, but probably worth talking about before merging. EDIT: Thinking about it more, as long as Datafusion can handle the newer version already, then I am fine with just doing the "faster" change, considering all of the other libraries can already handle it. |
99a8d02 to
9659aa1
Compare
|
I added code that outputs the old data structures in parallel as discussed in the community sync until we fully remove the old field via substrait-io/substrait#1002 |
benbellick
left a comment
There was a problem hiding this comment.
I think it looks good, just the one comment about making the tests a bit clearer. Thanks!
BREAKING CHANGE: changes RelProtoConverter to always output the new aggregate grouping proto structures Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
518edd4 to
3408fce
Compare
benbellick
left a comment
There was a problem hiding this comment.
LGTM, just a couple small comments. Thanks!
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
changes RelProtoConverter to output the new and the old aggregate grouping proto structures
relates to #299 and substrait-io/substrait#1002
This PR changes the
RelProtoConverterto output the new and the old grouping behavior keeping the existingio.substrait.relation.Aggregatebehavior the same.