Separate custom types into its own file and format#33
Conversation
|
Unfortunately there are some annoying
errors that ruff can't fix automatically and it's hard to make a generic solution for those since the syntax is dependent on context... |
Looks like this error will not happen if we use |
|
cbf1302 |
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
I've assumed that order in upstream file could change randomly on update so went with sorting. Maybe upstream file is updated manually in which case it wouldn't be a problem but I still like sorting anyway (in general) since it's easier to locate stuff. |
|
Hmm, but the generated types that I've included in LSP now don't match those here. In LSP I've used types after triggering ruff fix and then manually fixing remaining issues. We could also ignore those issues in LSP but then we'd have to update those again. But that's probably better than trying to fix the issue here. It will probably solve itself anyway after migrating to 3.14. |
|
I'm OK with this state. If you are too then I will update types in LSP to match those. |
👍
Yes, I think it would be good to also update LSP. (only for consistence) with future of python we can make adjustments to remove UP006, UP007 |
No description provided.