Add workflow to check pyfftw

[NimaSarajpoor]

No description provided.

[gitnotebooks]

Review these changes at https://app.gitnotebooks.com/stumpy-dev/automate/pull/7

[NimaSarajpoor]

@seanlaw
Okay... I think I should finish the sdp PR in STUMPY (stumpy-dev/stumpy#1118) first, and then gets successful run there (without checking pyfftw if it is not installed).... and then, after merging that PR, come back here.

[seanlaw]

I believe that the workflow needs to be merged first before it can have access to the token

I was totally wrong! A token is not needed in our case. A pixi token is only needed if you are managing packages at prefix.dev. I want to add a workflow for checking conda-forge builds using pixi (similar to checking our pypi builds). So I will test that out

[seanlaw]

@NimaSarajpoor We now have a pixi workflow that checks conda-forge;

https://github.com/stumpy-dev/automate/blob/main/.github/workflows/check-conda-forge-actions.yml

Hopefully, that helps you with this

[NimaSarajpoor]

@seanlaw

A pixi token is only needed if you are managing packages at prefix.dev.

👍

We now have a pixi workflow that checks conda-forge;
Hopefully, that helps you with this

Thanks for the work on this! A couple of questions:

(1) Do you suggest that we should use pixi instead of pip for installing STUMPY (and its dependencies)? and then install pyfftw and FFTW on top of those ?

(2) Are we planning to avoid using specific versions for setup-pixi and pixi in the future?

automate/.github/workflows/check-conda-forge-actions.yml

Lines 39 to 42 in 215ee5e

	- name: Set Up Pixi
	uses: prefix-dev/setup-pixi@v0.9.4
	with:
	pixi-version: v0.62.2

[seanlaw]

(1) Do you suggest that we should use pixi instead of pip for installing STUMPY (and its dependencies)? and then install pyfftw and FFTW on top of those ?

Yes, use pixi to install STUMPY and its dependencies. Then either add a workflow "step" to pixi add pyfftw fftw OR figure out how to add them to the pyproject.toml. The latter might be harder?

(2) Are we planning to avoid using specific versions for setup-pixi and pixi in the future?

Yes, we'll update it once setup-pixi stabilizes. I don't want to use dependabot. It's okay if the pixi-related workflows fail in the future. Note that I haven't fully confirmed that my steps are correct (in terms of whether or not I have successfully avoided installing STUMPY from source and, instead, installed it from conda-forge. I am 95% sure? Please take a look :)

[NimaSarajpoor]

@seanlaw

Note that I haven't fully confirmed that my steps are correct (in terms of whether or not I have successfully avoided installing STUMPY from source and, instead, installed it from conda-forge. I am 95% sure? Please take a look :)

I looked at your commits. I can see you delete [tool.pixi.activation] part of pyproject.toml to force pixi install STUMPY from Conda.

IIUC, we should install it from Source though regarding this PR. Right? I can see ray-actions.yml does the same thing, which makes sense because it allows us to check the tests on main.

[seanlaw]

IIUC, we should install it from Source though regarding this PR. Right? I can see ray-actions.yml does the same thing, which makes sense because it allows us to check the tests on main.

Yes, we should install from source

[NimaSarajpoor]

@seanlaw
The workflow installs STUMPY from source and it now installs fftw and pyfftw separately. Can you please let me know if any particular step in the workflow requires a change?

[seanlaw]

@NimaSarajpoor I think everything is good except for one section that needs to get removed

[NimaSarajpoor]

@seanlaw
Thanks for the review and catching my mistakes. Going to merge.

[NimaSarajpoor]

@seanlaw Thanks for the review and catching my mistakes. Going to merge.

@seanlaw
Just noticed there is no "merge" button on my end. Can you please merge once you get a chance?