build(deps): bump minimum coordinode requirement to >=0.4.0#18
Conversation
SDK is now stable at v0.4.x series. Closes #17
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe minimum required version constraint for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the LangChain and LlamaIndex adapters to require the stable CoordiNode Python SDK v0.4.x series (minimum coordinode>=0.4.0) instead of the prior alpha constraint.
Changes:
- Bumped
coordinodeminimum dependency from>=0.3.0a1to>=0.4.0inlangchain-coordinode. - Bumped
coordinodeminimum dependency from>=0.3.0a1to>=0.4.0inllama-index-coordinode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| langchain-coordinode/pyproject.toml | Updates adapter dependency floor to CoordiNode SDK >=0.4.0. |
| llama-index-coordinode/pyproject.toml | Updates adapter dependency floor to CoordiNode SDK >=0.4.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
langchain-coordinode/pyproject.toml (1)
25-25:⚠️ Potential issue | 🟠 MajorSame verification needed: test against coordinode 0.4.0+.
This file has the same concern as
llama-index-coordinode/pyproject.toml: the PR requirescoordinode>=0.4.0but tests only pass against 0.3.0. The langchain integration relies on these coordinode APIs:
CoordinodeClient(addr, timeout=timeout)constructor (graph.py:41-49)cypher(query, params={})method returningList[Dict[str, Any]](graph.py:176-192)get_schema_text()method (graph.py:68-90)Before merging, verify that:
- The coordinode 0.4.0 release contains no breaking changes to these APIs (see web search request in the previous file)
- Integration tests pass against coordinode 0.4.0+ versions
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@langchain-coordinode/pyproject.toml` at line 25, The pyproject pin for coordinode was updated to "coordinode>=0.4.0" but we haven't verified the integration; confirm that coordinode 0.4.0+ preserves the APIs used here (CoordinodeClient constructor used in graph.py around the init/constructor block, the cypher(query, params={}) method used where graph queries are executed, and get_schema_text() used when fetching schema), and then run the integration/unit test suite against coordinode 0.4.0+; if any API changed, update the calls in graph.py (constructor args, cypher return handling, or get_schema_text usage) to match the new signatures and adjust tests accordingly so the test matrix passes with coordinode>=0.4.0.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@llama-index-coordinode/pyproject.toml`:
- Line 25: The dependency pin "coordinode>=0.4.0" is invalid because v0.4.0
isn't released; update the requirement in pyproject.toml to a released version
such as "coordinode>=0.3.0" (or to a specific tested version like
"coordinode==0.3.0") so the package is publishable, or if you intentionally need
unreleased code switch to a git URL or local path and document that choice;
locate the dependency line containing "coordinode>=0.4.0" and replace it with
the chosen valid constraint or alternative source reference.
---
Duplicate comments:
In `@langchain-coordinode/pyproject.toml`:
- Line 25: The pyproject pin for coordinode was updated to "coordinode>=0.4.0"
but we haven't verified the integration; confirm that coordinode 0.4.0+
preserves the APIs used here (CoordinodeClient constructor used in graph.py
around the init/constructor block, the cypher(query, params={}) method used
where graph queries are executed, and get_schema_text() used when fetching
schema), and then run the integration/unit test suite against coordinode 0.4.0+;
if any API changed, update the calls in graph.py (constructor args, cypher
return handling, or get_schema_text usage) to match the new signatures and
adjust tests accordingly so the test matrix passes with coordinode>=0.4.0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 506cf016-4c8c-4443-bc6b-46050cdac086
📒 Files selected for processing (2)
langchain-coordinode/pyproject.tomlllama-index-coordinode/pyproject.toml
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Packages
The
coordinode>=0.4.0constraint refers to the Python SDK package on PyPI, not the CoordiNode database server version.Test Plan
coordinodePython SDK v0.4.4 against CoordiNode DB v0.3.0Closes #17