Skip to content

Experiment with ifdef-guarded changes to xdr #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leighmcculloch wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Draft

Experiment with ifdef-guarded changes to xdr #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9263678
update image tag and stellar-core ref for xdrifdef
leighmcculloch Feb 23, 2026
3aa68c6
add `--target stellar-core-stage` to build command
leighmcculloch Feb 23, 2026
0a54aeb
update image tag to latest and fix xdr flag
leighmcculloch Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ console:
$(CONTAINER_RUNTIME) exec -it stellar /bin/bash

build: $(IMAGE_JSON)
$(CONTAINER_RUNTIME) build -t stellar/quickstart:$(TAG) -f Dockerfile . \
$(CONTAINER_RUNTIME) build -t stellar/quickstart:$(TAG) -f Dockerfile --target stellar-core-stage . \
--build-arg REVISION=$(REVISION) \
--build-arg XDR_REPO=$(XDR_REPO) --build-arg XDR_REF=$(XDR_SHA) \
--build-arg CORE_REPO="$(CORE_REPO)" --build-arg CORE_REF="$(CORE_SHA)" --build-arg CORE_OPTIONS='$(CORE_OPTIONS)' \
Expand Down
4 changes: 2 additions & 2 deletions images.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
{
"name": "core",
"repo": "stellar/stellar-core",
"ref": "v25.1.1",
"ref": "2e45f3df2b07f8b53a02178c0fe57f3652199535",
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stellar-core reference has been changed from a stable version tag "v25.1.1" to a commit hash "2e45f3df2b07f8b53a02178c0fe57f3652199535". While using commit hashes is acceptable for experimental configurations (as seen in the "future" tag at line 166), this change is being applied to what was the "latest" tag, which is documented as containing "stable software, compatible with mainnet".

If this is meant to be an experimental build, ensure this configuration is in a separate experimental tag entry rather than replacing the stable "latest" configuration.

Suggested change
"ref": "2e45f3df2b07f8b53a02178c0fe57f3652199535",
"ref": "v25.1.1",

Copilot uses AI. Check for mistakes.
"options": {
"configure_flags": "--disable-tests"
"configure_flags": "--disable-tests --enable-xdr-transaction-meta-v5"
}
},
{
Expand Down
Loading