ci: fix Docker PR Release being skipped on beta-targeting PRs#494
Merged
steilerDev merged 2 commits intobetafrom Mar 6, 2026
Merged
ci: fix Docker PR Release being skipped on beta-targeting PRs#494steilerDev merged 2 commits intobetafrom
steilerDev merged 2 commits intobetafrom
Conversation
Adds full Playwright E2E test coverage for EPIC-04 (Household Items &
Furniture Management) which was previously only covered by a stub smoke
test. The household items pages are now fully implemented.
Changes:
- New e2e/tests/household-items/ directory with 4 spec files (80+ tests):
- household-items-list.spec.ts: list page, filters (category/status/room),
search, status badges, CRUD, pagination, responsive, dark mode, a11y
- household-item-create.spec.ts: create form, validation, navigation,
field options, responsive, dark mode
- household-item-detail.spec.ts: detail page, budget section, documents
section (Story 8.6), responsive, dark mode, 404 state
- household-item-edit.spec.ts: edit form, pre-population, save flow,
validation, navigation, responsive
- New POMs:
- e2e/pages/HouseholdItemCreatePage.ts — fully modelled create form
- e2e/pages/HouseholdItemDetailPage.ts — detail page locators
- e2e/pages/HouseholdItemsPage.ts — upgraded from stub to full POM
- Updated fixtures:
- e2e/fixtures/apiHelpers.ts — add createHouseholdItemViaApi/
deleteHouseholdItemViaApi helpers
- e2e/fixtures/testData.ts — add API.householdItems and
ROUTES.householdItemsNew constants
- Removed stub test for Household Items from stub-pages.spec.ts
(page has graduated to full feature — EPIC-04)
Co-Authored-By: Claude qa-integration-tester (Sonnet 4.6) <noreply@anthropic.com>
The quality-gates job depends on e2e and e2e-merge-reports, which are skipped for beta-targeting PRs (they only run for main). Even though quality-gates uses `if: !cancelled()` and succeeds, GitHub Actions' transitive skip propagation can auto-skip downstream jobs before their `if` condition is evaluated. Adding `!cancelled()` to docker-pr-release's condition prevents the auto-skip and ensures the `if` expression is always evaluated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.12.0-beta.52 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docker PR Releasejob was being skipped on beta-targeting PRs despite all conditions being metquality-gatesnow depends one2eande2e-merge-reports, which are skipped for beta PRs (they only run formain-targeting PRs). Even thoughquality-gatesusesif: !cancelled()and succeeds, GitHub Actions' transitive skip propagation auto-skips downstream jobs before theirifcondition is evaluated!cancelled()todocker-pr-release'sifcondition, preventing the auto-skip and ensuring the expression is always evaluatedEvidence
quality-gates: success,Docker PR Release: skippedDocker PR Release: successquality-gates: needs: [static-analysis, test](no e2e jobs)Test plan
app=false)🤖 Generated with Claude Code