fix(scheduling): correct critical path for terminal nodes#492
Merged
steilerDev merged 3 commits intobetafrom Mar 6, 2026
Merged
fix(scheduling): correct critical path for terminal nodes#492steilerDev merged 3 commits intobetafrom
steilerDev merged 3 commits intobetafrom
Conversation
Remove unused imports, variables, and functions. Prefix intentionally unused parameters with underscore. Replace `any` types with proper types. Fix React hook dependency arrays. Add justified eslint-disable comments for mock types in tests. Resolves 57 warnings across 23 files in client/, server/, and shared/. Co-Authored-By: Claude backend-developer (Haiku) <noreply@anthropic.com> Co-Authored-By: Claude frontend-developer (Haiku) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix destructured interface props that were incorrectly prefixed with underscore. Remove unused `milestones` from GanttSidebar destructuring (optional prop). Add eslint-disable for `activeTouchId` in CalendarHouseholdItem (required by interface but unused in component). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…al nodes Terminal nodes in the CPM backward pass were each using their own EF as their LF, giving every terminal node zero float and incorrectly marking them all as critical. Now computes a shared project finish date (max EF across all terminal nodes) so only the longest path has zero float. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.12.0-beta.51 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code