Skip to content

Handle DELETE method in ReadSignals #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bencroker wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Handle DELETE method in ReadSignals #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/starfederation/datastar/utils/SignalReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ public static void readSignals(RequestAdapter requestAdapter, ConcurrentMap<Stri

String data;

if ("GET".equalsIgnoreCase(requestAdapter.getMethod())) {
// Handle GET requests by parsing the `datastar` query parameter
if ("GET".equalsIgnoreCase(requestAdapter.getMethod()) || "DELETE".equalsIgnoreCase(requestAdapter.getMethod())) {
// Handle GET and DELETE requests by parsing the `datastar` query parameter
data = requestAdapter.getParameter(DATASTAR_KEY);
if (data == null || data.isBlank()) {
throw new IllegalArgumentException("Missing 'datastar' query parameter in GET request.");
Expand Down
Loading