Onboard Intake(2/3): introduce Intake#1124
Conversation
|
@devanshcache please note: All of this also applies to #1126 |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
36d80c8 to
5664361
Compare
rubenhoenle
left a comment
There was a problem hiding this comment.
Lot work needs to be done here.
0b06573 to
3e95e2d
Compare
|
@rubenhoenle this is ready for review. I also re-ran all examples from other subcommands to make sure they remain in sync |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
Keep active (don't have permission for labels). This PR is ready for review. |
rubenhoenle
left a comment
There was a problem hiding this comment.
LGTM apart from the open discussion
Co-authored-by: Ruben Hönle <git@hoenle.xyz>
84e1993 to
80da4fe
Compare
Description
Intake is composed of three components:
Intake runner has already been merged reference (#952) this PR is continuation of the one of two components of Intake (ticket)
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)