feat(ios) Accessibility Deferral Element and additions#598
Draft
RoyalPineapple wants to merge 4 commits intomainfrom
Draft
feat(ios) Accessibility Deferral Element and additions#598RoyalPineapple wants to merge 4 commits intomainfrom
RoyalPineapple wants to merge 4 commits intomainfrom
Conversation
RoyalPineapple
force-pushed
the
alex/migrateA11y
branch
from
3511a17 to
9d4dd5b
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
fe80b79 to
3eb1400
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
3 times, most recently
from
80b442d to
025d5b2
Compare
RoyalPineapple
commented
Dec 16, 2025
BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
commented
Dec 16, 2025
BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
commented
Dec 16, 2025
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
e1e19d9 to
c94d466
Compare
RoyalPineapple
changed the title
RoyalPineapple
commented
Jan 28, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
commented
Jan 28, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
commented
Jan 28, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
commented
Jan 28, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
2 times, most recently
from
a4cc843 to
ee29332
Compare
RoyalPineapple
commented
Jan 29, 2026
|
|
||
| func replaceContent(_ content: [AccessibilityDeferral.Content]?) { | ||
| deferredAccessibilityContent = content | ||
| internal func replaceContent(_ content: [AccessibilityDeferral.Content]?) { |
Collaborator
Author
There was a problem hiding this comment.
moving this internal as it doesn't need to be the responsibility of the consumer and this removes some foot guns
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
3 times, most recently
from
9ce750c to
d3c997d
Compare
RoyalPineapple
commented
Jan 29, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
changed the title
Contributor
johnnewman-square
left a comment
johnnewman-square
left a comment
There was a problem hiding this comment.
These changes look good. I'm going to give the Market integration a pass and will circle back.
I think it would be great if we could add new unit tests for these deferral updates, if possible.
Comment on lines
+346
to
+349
| mergeValues = deferred.dropFirst() | ||
| .reduce(into: first) { result, value in | ||
| result.merge(with: value) | ||
| } |
Contributor
There was a problem hiding this comment.
Will the result of result.merge(with: value) be discarded here? I wonder if we could tweak this reduce pattern just a bit and add a unit test that captures this particular flow.
Comment on lines
+148
to
+152
|
|
||
| /// Creates a `ReceiverContainer` element to expose the deferred accessibility. | ||
| public func deferredAccessibilityReceiver(identifiers: [AnyHashable]) -> AccessibilityDeferral.ReceiverContainer { | ||
| AccessibilityDeferral.ReceiverContainer(wrapping: { self }) | ||
| } |
Contributor
There was a problem hiding this comment.
Could we update this function to use or remove the identifiers parameter?
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
soroushsq
approved these changes
Mar 2, 2026
BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift
Outdated
Show resolved
Hide resolved
| /// - cornerRadius: The radius for rounded corners | ||
| public static func frame(_ rect: CGRect, cornerRadius: CGFloat = accessibilityCornerRadius) -> Self { | ||
| .init { | ||
| UIBezierPath(roundedRect: rect, cornerRadius: max(0, cornerRadius + accessibilityPathInset)) |
Contributor
There was a problem hiding this comment.
Can this really be negative?
Collaborator
Author
There was a problem hiding this comment.
yea, the path inset is -2 (this was derived through experimentation we did in market)
… element This introduces comprehensive accessibility deferral improvements: - Add ReceiverContainer element to expose deferred accessibility content - Add FrameProvider to centralize accessibility frame handling - Add merge() method to combine accessibility representations - Apply container frames and corner radius to accessibility paths - Refactor Receiver protocol with updateDeferredAccessibility callback - Make CombinableView extensible and add mergeValues support - Update array extensions to package visibility Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
f5a29e8 to
b16b63d
Compare
- Fix reduce bug in updateDeferredAccessibility where merge results were
discarded (reduce(into:) → reduce() since merge returns a new value)
- Remove unused identifiers parameter from deferredAccessibilityReceiver
- Fix typo in doc comment ("through he" → "through the")
- Simplify customContent type to Accessibility.CustomContent
- Remove redundant needsAccessibilityUpdate invalidation
- Add AccessibilityDeferralTests covering merge chaining, apply/replace
flow, and content generation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the accessibility deferral system with comprehensive improvements to frame handling and element composition.
Key Changes
AccessibilityDeferral.ReceiverContainerallowing arbitrary elements to receive deferred accessibility content without needing to conform to theAccessibilityDeferral.Receiverprotocol directlymerge()method onCompositeRepresentationto combine accessibility values from multiple sourcesReceiverprotocol withupdateDeferredAccessibility(frameProvider:)callback for frame-aware receiversCombinableViewextensible (changed fromfinalclass) and addsmergeValuesproperty for more flexible accessibility compositionTechnical Details
The
FrameProviderstruct provides a unified API for accessibility frame handling that enables UIView-based frame passthrough without taking a strong reference to the backing view.The
ReceiverContainerwraps any element and handles deferred accessibility application automatically, simplifying the integration of accessibility deferral in complex element hierarchies.