fix: allow ARCH and VERSION env overrides in install script#350
Open
fix: allow ARCH and VERSION env overrides in install script#350
Conversation
ARCH was unconditionally set from uname, and VERSION from PE_VERSION, ignoring any user-provided environment variables. Use parameter expansion defaults so user-supplied values take precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARCHwas unconditionally set fromuname -m, ignoring any user-providedARCHenv varVERSIONwas unconditionally set fromPE_VERSION, ignoring any user-providedVERSIONenv var${VAR:-default}parameter expansion so user-supplied values take precedenceTest plan
ARCH/VERSIONset — should auto-detect as beforeARCH=arm64set — should use the provided value instead ofuname -mVERSION=v1.0.0set — should use the provided value instead ofPE_VERSION