fix: percent-encode x-server-id header value#2071
fix: percent-encode x-server-id header value#2071atilafassina merged 2 commits intofix-server-id-encodingfrom
x-server-id header value#2071Conversation
🦋 Changeset detectedLatest commit: 9683199 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: atilafassina <2382552+atilafassina@users.noreply.github.com>
x-server-id header value
There was a problem hiding this comment.
Pull request overview
Adds a Changesets entry for a patch release describing a fix to X-Server-Id header encoding in @solidjs/start.
Changes:
- Added a new changeset documenting a patch fix for percent-encoding the
x-server-id/X-Server-Idheader value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --- | ||
| "@solidjs/start": patch | ||
| --- | ||
|
|
||
| fix: use percent encoding for `x-server-id` header value instead of reserved `#` character |
There was a problem hiding this comment.
This PR currently only adds a changeset, but the described behavioral fix (percent-encoding the X-Server-Id header value) doesn’t appear in the diff. Also, the current implementation already sets X-Server-Id using percent encoding (see packages/start/src/runtime/server-runtime.ts:128), so this changeset may be inaccurate or may ship a patch with no actual code change. Please either include the corresponding code change in this PR or adjust the PR/changelog to reflect the actual delta being released.
The
x-server-idheader value contained a raw#character, which is a reserved character in HTTP header syntax and can cause parsing issues.Changes
@solidjs/start: Replace#with its percent-encoded equivalent (%23) in thex-server-idheader value@solidjs/start💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.