Skip to content

Implement configuration resolution#656

Draft
ubaskota wants to merge 5 commits intodevelopfrom
config_resolution_main
Draft

Implement configuration resolution#656
ubaskota wants to merge 5 commits intodevelopfrom
config_resolution_main

Conversation

@ubaskota
Copy link

Issue #, if available:

Description of changes:
This PR implements the following:

  • Config source interface and environment variable source
  • Config resolver that resolves config values from sources
  • Config property descriptor along with a custom resolver and validators
  • Updates codegen files that generate config.py to support config resolution for newly added config variables:
    • retry_strategy, region and sdk_ua_app_id (in progress)
  • Unit tests covering all newly implemented features

Tests

  • Manual tests verifying config resolution for the added config variables
  • End-to-end tests from the generated client confirming expected resolution behavior
  • All existing tests pass

Note: There are 2 minor PRs yet to be merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…g resolution (#640)

* Add config source interface and environment variable source
* Add a ConfigResolver that goes through the list of sources to resolve config value
…idators (#642)

* Add a config property descriptor along with a custom resolver and validators
…solution. (#646)

* Update the codegen files that generate config.py to support config resolution.
* Replace raw source strings with typed SourceInfo dataclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant