Open
Conversation
robin-aws
force-pushed
the
smithy-jmespath-evaluator
branch
from
22cdbd1 to
571627d
Compare
mtdowling
force-pushed
the
smithy-jmespath-evaluator
branch
from
571627d to
3897b7b
Compare
…ithy-java into smithy-jmespath-evaluator # Conflicts: # gradle/libs.versions.toml # jmespath/src/main/java/software/amazon/smithy/java/jmespath/DocumentJmespathRuntime.java # jmespath/src/main/java/software/amazon/smithy/java/jmespath/GeneratedTypeJmespathRuntime.java
…-jmespath-evaluator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replaces the guts of the
JMESPathDocumentQuerylogic with the new JMESPath evaluation feature from core Smithy, together with aDocumentJmespathRuntimeadaptor. Also adds aGeneratedTypeJmespathRuntimeadaptor to allow evaluating JMESPath expressions directly against code-generated types (builtin types likeString,Boolean,Map, andList, together withSerializableStructand two newSmithyEnumandSmithyIntEnuminterfaces) to avoid having to convert to aDocumentfirst.Covered by existing tests, and hooking up the JMESPath compliance tests from
smithy-jmespath-testsfor both runtimes. Note that the copy of those tests in this project accidentally put the wrong content inslices.json, and missing those tests hid a few bugs in evaluating slices in the old logic! :)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.