Open
Conversation
Contributor
Author
f3.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an input conflict where pressing F3 would also trigger the host options menu
Changes
Previous Behavior
Whenever the player pressed F3 to see the debug information, the host options scene would also open simultaneously
Root Cause
The
KEY_DEBUG_INFOkey was triggering theMINECRAFT_ACTION_GAME_INFOflag causing the host options menu to openNew Behavior
F3 only toggles the on-screen debug info
Fix Implementation
KeyboardMouseInput.hto introduceKEY_DEBUG_MENUand mapped it to a separate key (F4), keeping F3 asKEY_DEBUG_INFO.Minecraft.cpp: instead of raising the `MINECRAFT_ACTION_GAME_INFO flag when pressing the debug key, it now correctly raises MINECRAFT_ACTION_RENDER_DEBUG.player->ullButtonsPressed&(1LL<<MINECRAFT_ACTION_RENDER_DEBUG)Related Issues