Fix softlocking on attempt to delete save games.

[Boom244]

Description

This is a stopgap solution designed to temporarily prevent game softlocking. The root of the issue lies in 4JStorage, which is currently being decompiled by the community. This PR, at the moment, simply prevents the game from softlocking when attempting to delete a save.

Changes

Toggled m_bIgnoreInput in UIScene_LoadOrJoinMenu::DeleteSaveDialogReturned after the call to C4JStorage::DeleteSaveData so that attempting to delete a save does not softlock the game.

Previous Behavior

Before, on attempting to delete a save game, the game would lock up and not allow you to navigate the Saves menu afterward, effectively softlocking you and forcing you to relaunch it.

Root Cause

I suspect there is behaviour in C4JStorage::DeleteSaveData that is supposed to allow the player to reclaim control of the menu that is currently non-functional. Further investigation will have to be done when the library is decompiled.

New Behavior

Deleting your games still doesn't delete them (as per above), but you are no longer softlocked.

Fix Implementation

Adding this right below the call to C4JStorage::DeleteSaveData:

 pClass->m_bIgnoreInput = false;

allows the player to reclaim control of the Saves menu.

Related Issues

• Related to Game softlocks when you attempt to delete a save from here - doesn't respond the neither controller inputs or keyboard inputs - forced to close the game and restart. #328.

[void2012]

4JLibs is 100% decompiled now