refactor: remove logger from activity, manifest, datastore, auth, and app delete/uninstall#364
Open
refactor: remove logger from activity, manifest, datastore, auth, and app delete/uninstall#364
Conversation
…, delete, and uninstall
mwbrooks
added
code health
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 65.06% 64.96% -0.11%
==========================================
Files 215 215
Lines 18179 18024 -155
==========================================
- Hits 11829 11710 -119
+ Misses 5254 5222 -32
+ Partials 1096 1092 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
commented
Mar 6, 2026
Member
Author
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
Leaving a few comments for the patience reviewers!
Comment on lines
-102
to
-125
| // Set up event logger and execute the command | ||
| log := newDeleteLogger(clients, cmd, team) | ||
| log.Data["appID"] = selection.App.AppID | ||
| env, err := apps.Delete(ctx, clients, log, team, selection.App, selection.Auth) | ||
|
|
||
| return env, err | ||
| } | ||
| // Execute the command | ||
| env, teamName, err := apps.Delete(ctx, clients, team, selection.App, selection.Auth) | ||
| if err != nil { | ||
| return env, err | ||
| } | ||
| printDeleteApp(ctx, clients, selection.App.AppID, teamName) | ||
|
|
||
| // newDeleteLogger creates a logger instance to receive event notifications | ||
| func newDeleteLogger(clients *shared.ClientFactory, cmd *cobra.Command, envName string) *logger.Logger { | ||
| ctx := cmd.Context() | ||
| return logger.New( | ||
| // OnEvent | ||
| func(event *logger.LogEvent) { | ||
| appID := event.DataToString("appID") | ||
| teamName := event.DataToString("teamName") | ||
| switch event.Name { | ||
| case "on_apps_delete_app_success": | ||
| printDeleteApp(ctx, clients, appID, teamName) | ||
| default: | ||
| // Ignore the event | ||
| } | ||
| }, | ||
| ) |
Member
Author
There was a problem hiding this comment.
note: This is a good example of a typical change.
|
|
||
| logger := newValidateLogger(clients, cmd) | ||
| log, warn, err := manifestValidateFunc(ctx, clients, logger, selection.App, token) | ||
| isValid, warn, err := manifestValidateFunc(ctx, clients, selection.App, token) |
Member
Author
There was a problem hiding this comment.
note: We now return isValid instead of log
| return types.App{}, "", slackerror.Wrap(err, slackerror.ErrAppRemove) | ||
| } | ||
|
|
||
| // Is this needed anymore? |
Member
Author
There was a problem hiding this comment.
note: The caller may not have access to the team name and only the team domain or team ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request is part 1 of removing
internal/loggerpackage and is focused on the straight-forward use-cases. It will be the largest, but simplest PR.internal/loggerdependency from 5 command groups (activity,manifest,datastore,auth, andapp delete/uninstall)*logger.LogEvent, with output printed directly by callersMotivation
The
internal/loggerpackage implements an event-driven pub-sub pattern whereinternal/pkg/emits named events through a logger andcmd/subscribes to those events with callbacks that print output. This indirection makes control flow harder to follow and has already been abandoned in newer commands (e.g.cmd/datastore/count.go) which return plain data and print directly.Test Steps
The ambitious can double-check the output against their production
slackinstallation.Requirements