SK-2675 fix date validation for month#683
Merged
skyflow-bharti merged 4 commits intorelease/26.3.4from Mar 26, 2026
Merged
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Devesh-Skyflow
approved these changes
Mar 25, 2026
saileshwar-skyflow
approved these changes
Mar 25, 2026
skyflow-bharti
added a commit
that referenced
this pull request
Mar 26, 2026
* SK-2675 fix date validation for month (#683) * SK-2610 fix the type gap to pass the nested objects * SK-2675 fix the date validation * SK-2675 add unit test for fixing the date validation * SK-2675 undo style change * [AUTOMATED] Release - 2.7.3-dev.71ebd92 * SK-2610 fix the type gap in styles to allow user to pass the nested objects (#682) * SK-2610 fix the type gap to pass the nested objects * [AUTOMATED] Release - 2.7.3-dev.3a4806e --------- Co-authored-by: skyflow-bharti <skyflow-bharti@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
EXPIRATION_DATE element allows invalid month values (e.g., 00 or >12) in Composable/Collect elements, certain invalid month values (e.g., 00, >12) are not rejected
Expected behaviour:
The month should be strictly validated within 01–12, and any value outside this range (e.g., 00, 13+) should be rejected.