Skip to content

Fix Base64 file upload failing on read-only filesystems #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Base64 file upload failing on read-only filesystems #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c7b882
fix: use os.CreateTemp instead of os.Create in GetFileForFileUpload f…
Copilot Mar 25, 2026
4319e20
Fix complete - all checks passed
Copilot Mar 25, 2026
d8fd673
revert: remove unrelated go.mod/go.sum changes from dependency resolu…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions v2/internal/helpers/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,14 @@ func GetFileForFileUpload(request common.FileUploadRequest) (*os.File, error) {
return file, nil
}
if request.Base64 != "" {
if request.FileName == "" {
return nil, fmt.Errorf("FileName is required when Base64 is provided")
}
data, err := base64.StdEncoding.DecodeString(request.Base64)
if err != nil {
return nil, fmt.Errorf("failed to decode base64: %w", err)
}
file, err := os.Create(request.FileName)
file, err := os.CreateTemp("", request.FileName)
if err != nil {
return nil, fmt.Errorf("failed to create file: %w", err)
}
Expand All @@ -318,7 +321,7 @@ func GetFileForFileUpload(request common.FileUploadRequest) (*os.File, error) {
file.Seek(0, io.SeekStart)

// Remove from disk but keep open
os.Remove(request.FileName)
os.Remove(file.Name())
return file, nil
}

Expand Down
2 changes: 1 addition & 1 deletion v2/internal/helpers/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ MIIBAAIBADANINVALIDKEY==
Expect(err).To(BeNil())
})
It("should return error for invalid base64 data", func() {
_, err := GetFileForFileUpload(common.FileUploadRequest{Base64: "invalid_base64"})
_, err := GetFileForFileUpload(common.FileUploadRequest{Base64: "invalid_base64", FileName: "test.txt"})
Expect(err).ToNot(BeNil())
Expect(err.Error()).To(ContainSubstring("illegal base64 data at input byte"))
})
Expand Down