Tighten tolerances in event finding routines#561
Tighten tolerances in event finding routines#561JoshPaterson wants to merge 1 commit intoskyfielders:masterfrom
Conversation
|
This test is failing at line 68: python-skyfield/skyfield/tests/test_almanac_searches.py Lines 56 to 68 in a30a3e5 Fixing it will have to wait until tomorrow. If it's obvious to you feel free to make whatever changes are necessary. |
There's no problem with waiting til tomorrow! See what you can do about the test first; I'll probably first respond about broader issues before diving in to specific tests. |
|
This was finally solved last year in the following commit: I didn't notice at the time that this pull request can thereby be closed. Thanks for looking into this when it was first reported, and doing some early experiments! |
Fixes #559.
This PR tightens tolerances as discussed in #559. It's enough to fix the particular bugs in that issue, and makes that kind of bug less likely but doesn't completely prevent it. Do you think these tolerances should be decreased more so errors are even less likely?
Ideally there would be a more thorough fix that would make those kind of bugs impossible rather than just unlikely. I'll keep thinking about it, but for now this is enough to get @bmatthiesen's scripts working.