Jpportier/devexp 1309 use event destinations and sinch events (Voice)#325
Open
JPPortier wants to merge 5 commits intofeat/V2.0-nextfrom
Open
Conversation
JPPortier
requested review from
asein-sinch,
matsk-sinch and
rpredescu-sinch
as code owners
Contributor
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
JPPortier
changed the title
asein-sinch
reviewed
Mar 18, 2026
|
|
||
| /** | ||
| * WebHooksService Service instance | ||
| * SinchEventsService Service instance |
Contributor
There was a problem hiding this comment.
Careful, you'll have a conflict with the conversation PR
|
|
||
| /** | ||
| * WebHooksService Service instance | ||
| * SinchEventsService Service instance |
Contributor
There was a problem hiding this comment.
And here with the SMS PR too
| @@ -45,7 +45,7 @@ public interface VoiceService { | |||
| * Webhooks helpers instance | |||
Contributor
There was a problem hiding this comment.
Update the Javadoc too
| @RequestHeader Map<String, String> headers, @RequestBody String body) { | ||
|
|
||
| WebHooksService webhooks = sinchClient.voice().v1().webhooks(); | ||
| SinchEventsService webhooks = sinchClient.voice().v1().sinchEvents(); |
Contributor
There was a problem hiding this comment.
Rename the variable too
| | Old interface | New Equivalent in `voice().v1()` | | ||
| |-------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | applications() | [v1().applications()](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/api/v1/ApplicationsService.html) | | ||
| | applications().getCallbackUrls() | [v1().applications().getEventDestinations](https://www.javadoc.io/doc/com.sinch.sdk/sinch-sdk-java/2.0.0/com/sinch/sdk/domains/voice/api/v1/ApplicationsService.html#getEventDestinations(java.lang.String)) | |
Contributor
There was a problem hiding this comment.
Nit: A function should contain the trailing ()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.