chore: dotfiles cleanup and portability fixes

[simonasr]

Summary

• Bug fixes: broken zsh syntax, wrong username in gitconfig safe.directory, hardcoded rbenv PATH
• Portability: existence guards on all external source calls, $HOME/$USER instead of hardcoded paths in install scripts
• Deprecated: removed EOL OpenSSL 1.1 workaround, deprecated homebrew/cask-fonts tap
• Cleanup: removed dead check_overcommit() + precmd() code, commented-out tfenv/terragrunt lines, redundant f_hammerspoon_init.lua config.yaml entry, and orphan windows.lua_ / windows-bindings-defaults.lua_ files

Test plan

• Open a new terminal — zsh should start without errors
• Run dotdrop install -p <profile> — no conflicts from config.yaml changes
• Confirm ~/.gitconfig has safe.directory = ~/.goenv
• Verify bash -n install/brew-install.sh passes syntax check

Co-Authored-By: Claude AI

[Copilot]

Pull request overview

This PR aims to improve dotfiles portability and reduce setup friction by removing hardcoded user paths, adding guards around optional shell integrations, and cleaning up dotdrop configuration entries.

Changes:

• Replace hardcoded usernames/paths in install scripts and shell config with $HOME / $USER.
• Add file-existence checks before sourcing optional zsh plugins/scripts and guard thefuck initialization.
• Clean up dotdrop config.yaml (remove redundant Hammerspoon init mapping) and adjust git safe.directory.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
install/mac-bootstrap.sh	Uses $HOME for writing brew shellenv into the user’s zprofile.
install/git-clone-installs.sh	Replaces hardcoded username in chown with $USER.
install/brew-install.sh	Removes the homebrew/cask-fonts tap and installs Fira Code cask directly.
dotfiles/zshrc	Adds guards around optional source calls and thefuck; updates rbenv PATH.
dotfiles/gitconfig	Updates safe.directory to use ~/.goenv instead of a hardcoded home path.
config.yaml	Removes redundant explicit mapping for ~/.hammerspoon/init.lua and profile reference.

Comments suppressed due to low confidence (1)

dotfiles/zshrc:147

• rbinit/goinit are executed unconditionally, but the install scripts in this repo don't install rbenv or goenv (and goenv clone is commented out), so a fresh terminal session can error with "command not found". Consider guarding these initializations with command -v rbenv/goenv checks, similar to the thefuck guard.

# init all envs
alias init='pyinit;rbinit;goinit'
# pyinit
rbinit
goinit

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

safe.directory expects an absolute path in many Git versions; ~ is not consistently expanded for this setting, which can leave the repo still treated as unsafe. To keep this portable, consider setting this value via an install step that writes the absolute $HOME/.goenv path (e.g., git config --global --add safe.directory ...) or use dotdrop templating to render an absolute path per machine.

[Copilot]

This append is not idempotent: re-running the bootstrap will keep adding another identical brew shellenv line to ~/.zprofile. Consider only adding it if it's not already present (e.g., grep check) or using a managed block.

Suggested change

	echo 'eval "$(/opt/homebrew/bin/brew shellenv)"' >> "$HOME/.zprofile"
	if ! grep -q 'eval "$(/opt/homebrew/bin/brew shellenv)"' "$HOME/.zprofile" 2>/dev/null; then
	echo 'eval "$(/opt/homebrew/bin/brew shellenv)"' >> "$HOME/.zprofile"
	fi

[Copilot]

If this script is ever executed under sudo, $USER will typically be root, so these chown calls would incorrectly change ownership to root. Prefer using ${SUDO_USER:-$USER} (or similar) to ensure ownership is set back to the invoking user.

Suggested change

	sudo chown -R "$USER" ~/.config/
	sudo chown -R "$USER" ~/.local/share
	sudo chown -R "${SUDO_USER:-$USER}" ~/.config/
	sudo chown -R "${SUDO_USER:-$USER}" ~/.local/share

[Copilot]

This source is still unconditional. In config.yaml, f_zsh_git_aliases is only installed for some profiles (e.g. Simonass-MacBook-Pro.local) and not for others (e.g. Simonass-Air.lan), so zsh can error on startup. Either guard it with -f like the other source calls, or ensure the dotfile is included in every profile that installs f_zshrc.