fix: Replace deprecated kube-rbac-proxy with built-in metrics auth#285
Open
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
Open
fix: Replace deprecated kube-rbac-proxy with built-in metrics auth#285IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
0f4687a to
f14cd66
Compare
Member
Author
|
/cc @hasanawad94 |
Member
|
/hold We are going to merge #283 first, since this swaps the rbac-proxy-image with its new location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replaced the
kube-rbac-proxysidecar (the image is no longer available) with controller-runtime's built-in metrics authentication and authorization (filters.WithAuthenticationAndAuthorization).Key changes:
main.go: The metrics endpoint is now served directly on :8443 with TLS and authn/authz; no sidecar is needed.config/default/manager_auth_proxy_patch.yaml: Deleted (this previously injected the sidecar).config/rbac/auth_proxy_role.yamlandauth_proxy_role_binding.yaml: Deleted (permissions moved to Kubebuilder markers and auto-generated intorole.yaml).config/manager/manager.yaml: Added the metrics port and bind address (previously injected by the sidecar patch).Verification:
/kind bug
/kind cleanup
Fixes #284
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes