fix[ci]: update create-release action with gh cli

[kaizakin]

Changes

Fixes #166

This PR removes the use of depreceated action actions/create-release and adds gh cli to create releases

reason for choosing gh cli over another action:

• zero install time
• this issue of actions going unmaintained won't happen again

/kind cleanup

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

[kaizakin]

I have tested it as well
here's the workflow run: https://github.com/kaizakin/operator/actions/workflows/test-release.yml

[adambkaplan]

/ok-to-test

[kaizakin]

Hey @IrvingMg, Suggested changes has been made and ready for review 😀

[IrvingMg]

Thanks for the changes!

/lgtm

[adambkaplan]

/assign @hasanawad94

For approval

[IrvingMg]

/ok-to-test

[IrvingMg]

@kaizakin, could you rebase onto main and push? I guess that should retrigger the CI.

[IrvingMg]

/ok-to-test

[IrvingMg]

/lgtm

The CI issue has been identified and not related to these changes: #280

[hasanawad94]

/lgtm
/approve

[hasanawad94]

@IrvingMg can you rebase please. Lets verify if ci will pass now

[kaizakin]

e2e tests failed again 🥲

I suspect this is the issue i found in logs

    containerStatuses:
    - image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
      imageID: ""
      lastState: {}
      name: kube-rbac-proxy
      ready: false
      restartCount: 0
      started: false
      state:
        waiting:
          message: 'Back-off pulling image "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0":
            ErrImagePull: rpc error: code = NotFound desc = failed to pull and unpack
            image "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0": failed to resolve reference
            "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0": gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0:
            not found'
          reason: ImagePullBackOff

@hasanawad94

[IrvingMg]

Yeah, I saw this issue locally as well. It seems to be related to this old image gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0.

Let's see if /lgtm move this PR forward, as the failure is not related to this change.

/lgtm

[kaizakin]

Thanks for checking Irving

i have created an issue for the same #284

@IrvingMg @hasanawad94

[IrvingMg]

@kaizakin could you please rebase? Since #283 has been merged, the CI should pass now.

[hasanawad94]

/ok-to-test

[hasanawad94]

/lgtm

[hasanawad94]

/LGTM
/APPROVE

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasanawad94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hasanawad94]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment