fix: reduce detach latency and stabilize detach path#324
Open
tobwen wants to merge 2 commits intoshell-pool:masterfrom
Open
fix: reduce detach latency and stabilize detach path#324tobwen wants to merge 2 commits intoshell-pool:masterfrom
tobwen wants to merge 2 commits intoshell-pool:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #323, detach latency by making detach path responsive with faster polling and adaptive backoff in client protocol loop.
Changes
JOIN_POLL_DURATIONfrom 100ms to 10ms inlibshpool/src/consts.rsfor faster thread join pollingSHELL_TO_CLIENT_POLL_MSfrom 100 to 10 inlibshpool/src/daemon/shell.rsfor faster detach/reattach detectionlibshpool/src/daemon/shell.rslibshpool/src/protocol.rsto check stop flag during sleep intervalsBehavior
Before this fix
After this fix
Rationale
The previous polling intervals (100ms) were too conservative, causing noticeable latency in the detach operation. By reducing polling to 10ms and implementing adaptive backoff, detach becomes responsive while maintaining compatibility with existing shutdown flows and avoiding busy waits.
Tests
No tests have been added or modified.