feat: add attach background mode#321
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f6830cb to
ff107a2
Compare
ethanpailes
left a comment
There was a problem hiding this comment.
Just one little nit. Overall, this looks great. Seems like a good feature and the code and tests all look clean.
|
Looks like there are some lints that are grumpy at you. Feel free to just suppress the too-many-args one. |
ff107a2 to
2f688c8
Compare
2f688c8 to
8aff798
Compare
|
Looks like there are still some lint failures. To suppress the failure, you should add a |
Sorry for the noise. I added it now. |
|
Looks like a flaky test since they passed before and the only change is a lint suppression. I'm just going to merge. |
Summary
Adds
-b/--backgroundflag toshpool attachfor creating sessions with commands and immediate detach. resolves #320Changes
-b/--backgroundCLI flag (mutually exclusive with--attach-only)attach_implin libshpool/src/attach.rs to return connected client beforepipe_bytesBehavior
With background flag:
Rationale
Useful for:
Testing
Run integration tests:
cargo test --test attach backgroundTests
busy_background: Error when attaching to busy session with background flagbackground_custom_cmd: Basic background command executionbusy_background_force: Validates-f+-brestriction