fix stale autodaemonize cleanup#318
Merged
ethanpailes merged 1 commit intoshell-pool:masterfrom Mar 3, 2026
Merged
Conversation
ethanpailes
approved these changes
Mar 2, 2026
Contributor
ethanpailes
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this!
Contributor
|
Looks like there are some formatting issues that need fixing. |
Contributor
Author
|
rebased and applied the cargo fmt changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shpool's daemon is killed, it may not be able to clean up its daemon. This will result in an error "daemonizing: launched daemon, but control socket never came up".
The fix is to detect a
ConnectionRefusederror and treat it as a dead daemon, unlinking the socket before attempting to start the daemon.Test:
shpool attach fookillall -9 shpoolshpool attach foo