Skip to content

fix stale autodaemonize cleanup#318

Merged
ethanpailes merged 1 commit intoshell-pool:masterfrom
CGamesPlay:master
Mar 3, 2026
Merged

fix stale autodaemonize cleanup#318
ethanpailes merged 1 commit intoshell-pool:masterfrom
CGamesPlay:master

Conversation

@CGamesPlay
Copy link
Contributor

When shpool's daemon is killed, it may not be able to clean up its daemon. This will result in an error "daemonizing: launched daemon, but control socket never came up".

The fix is to detect a ConnectionRefused error and treat it as a dead daemon, unlinking the socket before attempting to start the daemon.

Test:

  • shpool attach foo
  • In a different terminal, killall -9 shpool
  • shpool attach foo

Copy link
Contributor

@ethanpailes ethanpailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@ethanpailes
Copy link
Contributor

Looks like there are some formatting issues that need fixing.

@CGamesPlay
Copy link
Contributor Author

CGamesPlay commented Mar 3, 2026

rebased and applied the cargo fmt changes

@ethanpailes ethanpailes merged commit 0fb1684 into shell-pool:master Mar 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants