Skip to content

Settings Screen Refactor#654

Merged
mpretty-cyro merged 20 commits intosession-foundation:devfrom
RyanRory:refactor-settings-screen
Mar 6, 2026
Merged

Settings Screen Refactor#654
mpretty-cyro merged 20 commits intosession-foundation:devfrom
RyanRory:refactor-settings-screen

Conversation

@RyanRory
Copy link
Collaborator

@RyanRory RyanRory commented Dec 18, 2025 •
edited
Loading

  • Refactored SettingsViewModel to be using SwiftUI SessionListScreen
  • Added more List Item components
  • Added SwiftUI version for some UIKit components

@RyanRory RyanRory changed the base branch from master to dev December 18, 2025 22:34
@RyanRory RyanRory changed the title [WIP] Settings Screen Refactor Settings Screen Refactor Jan 13, 2026
@RyanRory RyanRory marked this pull request as ready for review January 13, 2026 23:03
@RyanRory RyanRory requested a review from mpretty-cyro January 13, 2026 23:03
@RyanRory RyanRory added enhancement New feature or request Jira This ticket is being tracked in Jira labels Jan 14, 2026
@RyanRory RyanRory self-assigned this Jan 14, 2026
mpretty-cyro
mpretty-cyro requested changes Mar 1, 2026
View reviewed changes
Copy link
Collaborator

@mpretty-cyro mpretty-cyro left a comment •
edited by RyanRory
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few bugs while testing:

  • Pressing on the menu items has no highlighted state
  • Highlighted state for rounded rectangle buttons isn't clipping (Screenshot 1)

Screenshot 1

Image

@RyanRory
Copy link
Collaborator Author

RyanRory commented Mar 2, 2026

Found a few bugs while testing:

  • Pressing on the menu items has no highlighted state
  • Highlighted state for rounded rectangle buttons isn't clipping (Screenshot 1)

Screenshot 1

Image

Should both be working now.

@RyanRory RyanRory requested a review from mpretty-cyro March 2, 2026 23:15
mpretty-cyro
mpretty-cyro requested changes Mar 3, 2026
View reviewed changes
Copy link
Collaborator

@mpretty-cyro mpretty-cyro left a comment •
edited by RyanRory
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pressing items which are non-standard buttons (see screenshots) incorrectly highlights
  • If you drag to scroll the screen starting from one of the items it won't actually drag the screen (instead it triggers the highlight)
Image Image

@RyanRory RyanRory requested a review from mpretty-cyro March 3, 2026 05:13
@mpretty-cyro mpretty-cyro merged commit 52d08ae into session-foundation:dev Mar 6, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpretty-cyro mpretty-cyro mpretty-cyro approved these changes

Assignees

@RyanRory RyanRory

Labels

enhancement New feature or request Jira This ticket is being tracked in Jira

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RyanRory @mpretty-cyro