SES-5267 : Fix of echo during calls. (AEC/NS)#2030
Open
Conversation
|
|
||
| // Some devices won't fully apply a working input route until we explicitly refresh device state | ||
| // after entering MODE_IN_COMMUNICATION. | ||
| setMicrophoneMute(false) |
Collaborator
There was a problem hiding this comment.
What happens if someone makes a call and manually mutes right away, will we unmute them?
Collaborator
Author
There was a problem hiding this comment.
Ah yeah it might. I pushed an update to clean this up.
| val adm = JavaAudioDeviceModule.builder(context) | ||
| .setUseHardwareAcousticEchoCanceler(false) | ||
| .setUseHardwareNoiseSuppressor(false) | ||
| .createAudioDeviceModule() |
Collaborator
There was a problem hiding this comment.
These settings feel like the opposite of what we want?
Don't we actually want the noise suppression and echo cancellation?
Collaborator
Author
There was a problem hiding this comment.
This only cancels the hardware's noice cancellation and let WebRtc do the processing for it. If I'm not mistaken, webRtc's aec/ns is on by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An effort to fix the echoing during calls. Echoes and robotic voices might be caused by the hardware's own audio echo cancellation or noise suppression. This PR configures audioModule to use the software for this instead. Also included some
audioManagermode updates to make sure we can stay inMODE_IN_COMMUNICATIONproperly.