[Fix_#1198] Fix exception propagation by fjtirado · Pull Request #1204 · serverlessworkflow/sdk-java

fjtirado · 2026-03-04T16:01:23Z

Fixes serverlessworkflow#1198 Signed-off-by: fjtirado <ftirados@redhat.com>

Copilot

Pull request overview

Fixes exception swallowing in TryExecutor.handleException() so that workflow errors propagate when no catch filter or when/exceptWhen predicate matches, aligning runtime behavior with the DSL spec and issue #1198.

Changes:

Update TryExecutor.handleException() to return a failed future when the catch does not match, instead of completing successfully by default.
Make RaiseExecutor tolerate missing optional error fields (title, detail) and correct how detail is resolved.
Add a new workflow sample + test covering the “catch does not match → error propagates” scenario; normalize sample namespaces.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
impl/test/src/test/resources/workflows-samples/try-catch-retry-reusable.yaml	Adjust sample workflow namespace to `test`.
impl/test/src/test/resources/workflows-samples/try-catch-retry-inline.yaml	Adjust sample workflow namespace to `test`.
impl/test/src/test/resources/workflows-samples/try-catch-not-match.yaml	New workflow sample where `catch.when` does not match and error should propagate.
impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java	Add regression test asserting non-matching catch propagates a `WorkflowException`.
impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java	Fix exception propagation when catch filters/predicates do not match.
impl/core/src/main/java/io/serverlessworkflow/impl/executors/RaiseExecutor.java	Avoid NPE on missing `title/detail` and correct `detail` resolver wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

Signed-off-by: fjtirado <ftirados@redhat.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

impl/test/src/test/resources/workflows-samples/try-catch-not-match-details.yaml

impl/test/src/test/resources/workflows-samples/try-catch-match-status.yaml

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java

impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java

impl/test/src/test/resources/workflows-samples/try-catch-error-variable.yaml

Signed-off-by: fjtirado <ftirados@redhat.com> Update impl/test/src/test/resources/workflows-samples/try-catch-not-match-details.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update impl/test/src/test/resources/workflows-samples/try-catch-match-status.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update impl/test/src/test/resources/workflows-samples/try-catch-error-variable.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 4, 2026 16:01

[Fix_#1198] Fix exception propagation

d576f6c

Fixes serverlessworkflow#1198 Signed-off-by: fjtirado <ftirados@redhat.com>

fjtirado force-pushed the Fix_#1198 branch from acbe8f1 to d576f6c Compare March 4, 2026 16:01

Copilot started reviewing on behalf of fjtirado March 4, 2026 16:01 View session

fjtirado marked this pull request as draft March 4, 2026 16:02

Copilot AI reviewed Mar 4, 2026

View reviewed changes

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java Outdated Show resolved Hide resolved

[Fix serverlessworkflow#1198] Fixing details comparison typo

391efc7

Signed-off-by: fjtirado <ftirados@redhat.com>

fjtirado force-pushed the Fix_#1198 branch from 34606b7 to 391efc7 Compare March 4, 2026 16:36

fjtirado marked this pull request as ready for review March 5, 2026 13:23

Copilot AI review requested due to automatic review settings March 5, 2026 13:23

fjtirado force-pushed the Fix_#1198 branch from 6c93d58 to 8c90906 Compare March 5, 2026 13:23

fjtirado requested review from mcruzdev and ricardozanini March 5, 2026 13:23

Copilot started reviewing on behalf of fjtirado March 5, 2026 13:23 View session

fjtirado force-pushed the Fix_#1198 branch from 8c90906 to 83b6de2 Compare March 5, 2026 13:25

[Fix serverlessworkflow#1198] Adding error variable

dd6c143

Signed-off-by: fjtirado <ftirados@redhat.com>

fjtirado force-pushed the Fix_#1198 branch from 83b6de2 to dd6c143 Compare March 5, 2026 13:25

Copilot AI reviewed Mar 5, 2026

View reviewed changes

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java Outdated Show resolved Hide resolved

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java Show resolved Hide resolved

fjtirado marked this pull request as draft March 5, 2026 13:48

fjtirado marked this pull request as ready for review March 5, 2026 13:55

Copilot AI review requested due to automatic review settings March 5, 2026 13:55

Copilot started reviewing on behalf of fjtirado March 5, 2026 13:56 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml Outdated Show resolved Hide resolved

fjtirado force-pushed the Fix_#1198 branch from d60a31f to f73c64d Compare March 5, 2026 14:02

Copilot AI review requested due to automatic review settings March 5, 2026 14:08

fjtirado force-pushed the Fix_#1198 branch from f73c64d to af60d76 Compare March 5, 2026 14:08

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Copilot started reviewing on behalf of fjtirado March 5, 2026 14:15 View session

Copilot AI review requested due to automatic review settings March 5, 2026 14:19

fjtirado force-pushed the Fix_#1198 branch from ec3ad76 to 4e7a9a4 Compare March 5, 2026 14:21

mcruzdev approved these changes Mar 5, 2026

View reviewed changes

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 5, 2026 14:34

fjtirado force-pushed the Fix_#1198 branch from c82cf04 to 60a86c3 Compare March 5, 2026 14:35

Copilot AI reviewed Mar 5, 2026

View reviewed changes

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java Show resolved Hide resolved

impl/test/src/test/resources/workflows-samples/try-catch-error-variable.yaml Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of fjtirado March 5, 2026 14:41 View session

fjtirado force-pushed the Fix_#1198 branch from 60a86c3 to c9b754a Compare March 5, 2026 14:42

Copilot started reviewing on behalf of fjtirado March 5, 2026 14:46 View session

Copilot AI review requested due to automatic review settings March 5, 2026 15:59

Copilot started reviewing on behalf of fjtirado March 5, 2026 16:00 View session

fjtirado force-pushed the Fix_#1198 branch from b52e4a8 to 14159d5 Compare March 5, 2026 16:02

fjtirado force-pushed the Fix_#1198 branch from 14159d5 to c8083bd Compare March 5, 2026 16:05

Copilot AI reviewed Mar 5, 2026

View reviewed changes

ricardozanini approved these changes Mar 5, 2026

View reviewed changes

fjtirado merged commit b9351b2 into serverlessworkflow:main Mar 5, 2026
3 checks passed

Conversation

fjtirado commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants