Fix EventletConnection close() race: set last_error to prevent returning dead connections#702
Draft
dkropachev wants to merge 1 commit intomasterfrom
Draft
Fix EventletConnection close() race: set last_error to prevent returning dead connections#702dkropachev wants to merge 1 commit intomasterfrom
dkropachev wants to merge 1 commit intomasterfrom
Conversation
dkropachev
force-pushed
the
fix/eventlet-close-race-614
branch
from
ac1f652 to
08535c5
Compare
EventletConnection.close() uses blocking kill() which mostly prevents races, but if close() is called from a non-eventlet thread the greenthread may not be interrupted as expected. - Add is_closed/is_defunct guards in handle_read() and handle_write() error paths to silently exit during shutdown - Set last_error in close() when connected_event is not yet set to prevent factory() from returning a dead connection - Set last_error on server-initiated close (EOF) in handle_read()
dkropachev
force-pushed
the
fix/eventlet-close-race-614
branch
from
08535c5 to
d30278c
Compare
dkropachev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in
EventletConnection.close()wherefactory()could return a dead connection becauselast_errorwas never set.close()is called before the handshake completes (connected_eventnot yet set),factory()checkslast_errorto decide whether to return the connection. Withoutlast_errorset, it could return a connection that was already closed.handle_read()),last_errorwas not set before callingclose(), leading to the same issue.Changes
last_errorinclose()whenconnected_eventhas not been set yet, sofactory()knows the connection failedlast_erroron server-initiated close (EOF) inhandle_read()before callingclose()Test plan
EVENT_LOOP_MANAGER=eventlet uv run pytest tests/unit/io/test_eventletreactor.pypassesRefs #614