tests: enable vector integration tests on Scylla 2025.4+#698
Open
mykaul wants to merge 1 commit intoscylladb:masterfrom
Open
tests: enable vector integration tests on Scylla 2025.4+#698mykaul wants to merge 1 commit intoscylladb:masterfrom
mykaul wants to merge 1 commit intoscylladb:masterfrom
Conversation
Vector type is supported on Scylla 2025.4 and above. Enable the integration tests. Tested locally against both 2025.4.2 and 2026.1 and they pass. Tested locally against 2025.1, where it is skipped, as it should be. Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
Author
|
I'm pretty sure CI is broken :-/ |
Lorak-mmk
requested changes
Feb 16, 2026
Comment on lines
+282
to
+292
| def _is_cass50_or_scylla_2025_4_plus(): | ||
| if CASSANDRA_VERSION >= Version('5.0-beta'): | ||
| return True | ||
| if SCYLLA_VERSION is None: | ||
| return False | ||
| return Version(get_scylla_version(SCYLLA_VERSION)) >= Version('2025.4') | ||
|
|
||
| greaterthanorequalcass50_or_scylla_2025_4 = unittest.skipUnless( | ||
| _is_cass50_or_scylla_2025_4_plus(), | ||
| 'Cassandra >= 5.0 or Scylla >= 2025.4 required' | ||
| ) |
There was a problem hiding this comment.
Can you rename:
_is_cass50_or_scylla_2025_4_plus -> _has_vector_type
greaterthanorequalcass50_or_scylla_2025_4 -> requires_vector_type
?
And preferably move it to where other similar requirements live (like requires_collection_indexes).
Comment on lines
+282
to
+287
| def _is_cass50_or_scylla_2025_4_plus(): | ||
| if CASSANDRA_VERSION >= Version('5.0-beta'): | ||
| return True | ||
| if SCYLLA_VERSION is None: | ||
| return False | ||
| return Version(get_scylla_version(SCYLLA_VERSION)) >= Version('2025.4') |
There was a problem hiding this comment.
A bit more future-proof version, not depending on which CASSANDRA_VERSION scylla maps to:
def _has_vector_type():
if SCYLLA_VERSION is not None:
return Version(get_scylla_version(SCYLLA_VERSION)) >= Version('2025.4')
return CASSANDRA_VERSION >= Version('5.0-beta'):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector type is supported on Scylla 2025.4 and above. Enable the integration tests.
Tested locally against both 2025.4.2 and 2026.1 and they pass.
Tested locally against 2025.1, where it is skipped, as it should be.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.