Conversation
- add lean Tauri dev launcher using temporary Rust and Vite caches - add targeted and full local cleanup scripts for reproducible artifacts - document normal vs lean workflow and cleanup tradeoffs - make Vite cache directory configurable for ephemeral cache routing Tests: npm run build
- install global git and performance baseline payload - add codex-os manifest and verification contracts - align repo with global policies under /Users/d/.codex/policies Tests: not run (bootstrap scaffolding only)
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3820fb13a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| node-version: 20 | ||
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile |
There was a problem hiding this comment.
This step uses pnpm install --frozen-lockfile, but this commit still keeps npm as the package manager (package-lock.json is present and pnpm-lock.yaml is absent), so the install fails immediately with ERR_PNPM_NO_LOCKFILE before any perf checks run; the same install pattern appears across both perf workflows, so these jobs will fail on every PR until the lockfile strategy is made consistent.
Useful? React with 👍 / 👎.
| process.exit(2); | ||
| } | ||
|
|
||
| const ratio = (c - b) / b; |
There was a problem hiding this comment.
The regression ratio is computed as (c - b) / b without guarding b === 0, and this commit seeds .perf-baselines/build-time.json and .perf-baselines/bundle.json with zero values, so any positive metric produces an infinite ratio and always fails the enforced threshold check (while serializing as null in JSON), effectively blocking production-profile perf gates by default.
Useful? React with 👍 / 👎.
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm build || pnpm build:ui | ||
| - run: pnpm perf:lhci:prod || pnpm perf:lhci |
There was a problem hiding this comment.
This command falls back from pnpm perf:lhci:prod to pnpm perf:lhci, but neither script is defined in package.json, so when PERF_PROFILE == 'production' the perf-lighthouse job fails unconditionally with ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL instead of evaluating Lighthouse results.
Useful? React with 👍 / 👎.
Codacy's Analysis Summary100 new issues (≤ 0 issue) Review Pull Request in Codacy →
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| command: "npm_execpath run build", | ||
| }, | ||
| null, | ||
| 2, |
There was a problem hiding this comment.
Codacy has a fix for the issue: ES2017 trailing commas in parameter/argument lists are forbidden.
| 2, | |
| 2 |
1 participant
What
Why
Testing
Risk / Notes
.codex/bootstrap-conflicts/*.newfiles and merge intentionally