Conversation
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several TopbarPlus-based client HUD icons to render using Roblox BuilderIcons (icon-font glyphs) instead of image asset IDs, aligning topbar icon visuals with a font-driven icon system.
Changes:
- Replace default
IconImagevalues fromrbxasset*image IDs to BuilderIcons glyph names (e.g."photo-camera","phone"). - Switch icon rendering from
icon:setImage(...)toicon:setLabel(...)with BuilderIcons font configuration (size + selected/deselected font weights). - Remove per-icon image scaling calls (
setImageScale(...)) since images are no longer used.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
src/client/ScreenshotHud.client.luau |
Uses BuilderIcons glyph label/font for the ScreenshotHud topbar icon instead of an image asset. |
src/client/PlayerFeedback.client.luau |
Updates feedback topbar icon to a BuilderIcons glyph with font configuration. |
src/client/PhoneBook.client.luau |
Updates phone book topbar icon to a BuilderIcons glyph with font configuration. |
src/client/GameInvite.client.luau |
Updates invite friends topbar icon to a BuilderIcons glyph with font configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.