Open
Conversation
GrymnDolen
commented
Sep 14, 2023
GrymnDolen
commented
There was a problem hiding this comment.
Pull request overview
This PR adjusts winrm-exec.py stdout/locale configuration and modifies how command output is decoded/written, aiming to improve special-character handling and Windows console compatibility.
Changes:
- Adds locale and stdout encoding configuration at import time.
- Introduces a hard-coded
cp437decoding path when streaming command output. - Minor refactor/formatting in the output read loop (variable spacing, extra error handling).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+19
to
+20
| sys.stdout.reconfigure(encoding='utf-8') | ||
| locale.setlocale(locale.LC_ALL, 'fr_FR.utf8') |
| import codecs | ||
|
|
||
| sys.stdout.reconfigure(encoding='utf-8') | ||
| locale.setlocale(locale.LC_ALL, 'fr_FR.utf8') |
| from colored_formatter import ColoredFormatter | ||
|
|
||
| import locale | ||
| import codecs |
Comment on lines
+307
to
+308
| output_charset = 'cp437' | ||
|
|
Comment on lines
323
to
326
| except UnicodeDecodeError: | ||
| try: | ||
| realstdout.write(read.decode(DEFAULT_CHARSET)) | ||
| realstdout.write(read.decode('cp437', errors='replace')) | ||
| except Exception as e: |
| except Exception as e: | ||
| log.error(e) | ||
|
|
||
| log.error(e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.