Skip to content

Remove rbs:annotate from GHA#48

Merged
hsbt merged 2 commits intomasterfrom
remove-annotate
Feb 12, 2026
Merged

Remove rbs:annotate from GHA#48
hsbt merged 2 commits intomasterfrom
remove-annotate

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Feb 12, 2026

from #46

Copilot AI review requested due to automatic review settings February 12, 2026 02:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the rbs:annotate task from the GitHub Actions CI workflow for RBS signature validation. The change is related to PR #46 which fixed the sig files with the latest behavior. The workflow now only runs rbs:test (to test type signatures) and rbs:confirm (to verify signatures are up-to-date), removing the intermediate annotation step that was previously part of the pipeline.

Changes:

  • Removed rbs:annotate from the sig.yml workflow, simplifying the CI process to only test and confirm RBS signatures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ksss
Copy link
Contributor

ksss commented Feb 12, 2026

If we don't use the rbs:annotate task, we don't need the rbs:confirm task either.

@hsbt
Copy link
Member Author

hsbt commented Feb 12, 2026

@copilot Please apply #48 (comment)

Copy link
Contributor

Copilot AI commented Feb 12, 2026

@hsbt I've opened a new pull request, #49, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: hsbt <12301+hsbt@users.noreply.github.com>
@hsbt hsbt merged commit c0357ef into master Feb 12, 2026
86 checks passed
@hsbt hsbt deleted the remove-annotate branch February 12, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants