Skip to content

Fixing regions props node attribute init#259

Open
JoOkuma wants to merge 17 commits intoroyerlab:mainfrom
JoOkuma:jookuma/fix-regionprops-init
Open

Fixing regions props node attribute init#259
JoOkuma wants to merge 17 commits intoroyerlab:mainfrom
JoOkuma:jookuma/fix-regionprops-init

Conversation

@JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented Feb 13, 2026

No description provided.

@yfukai
Copy link
Contributor

yfukai commented Feb 17, 2026

Hi, I'm sorry for my absence for a while @JoOkuma, I believe you're working on #191, but am I right?

@JoOkuma
Copy link
Member Author

JoOkuma commented Feb 17, 2026

Hi @yfukai , yes.
I've found a few issues with the dtypes when they are array or other complex types, and there are null values.
It's not directly related to this, but arises from some of the regionprops attributes.

@yfukai
Copy link
Contributor

yfukai commented Feb 26, 2026

Thanks @JoOkuma for this! I believe that arises from the dtype inference, and can be solved by #262 . Maybe you could give it a try.

@JoOkuma
Copy link
Member Author

JoOkuma commented Feb 26, 2026

@yfukai, #262 fixed this. The tests are passing locally for me.
We can merge this after #262 is merged.

@yfukai
Copy link
Contributor

yfukai commented Feb 27, 2026

Thanks! I feel sometimes we'd like to filter the nodes by the intensities of specific channels. Would it make sense to flatten the vector-like props? regionprops_table automatically does this, and I was wondering if we could use this instead.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 86.45833% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.76%. Comparing base (e4bb183) to head (3a17bdb).

Files with missing lines Patch % Lines
src/tracksdata/utils/_dtypes.py 71.83% 11 Missing and 9 partials ⚠️
src/tracksdata/graph/_sql_graph.py 95.50% 3 Missing and 1 partial ⚠️
src/tracksdata/nodes/_regionprops.py 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   87.92%   87.76%   -0.16%     
==========================================
  Files          56       56              
  Lines        4471     4611     +140     
  Branches      789      809      +20     
==========================================
+ Hits         3931     4047     +116     
- Misses        344      361      +17     
- Partials      196      203       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants