Fix Google Sheets sync dedup and stale row index bugs#7
Open
Conversation
- saveArticle/saveArticles now upsert instead of blindly appending, preventing duplicate rows when multiple devices save the same URL - batchUpdateArticles re-fetches fresh row numbers before writing, avoiding stale indices after concurrent sheet modifications - getArticles deduplicates by URL, keeping the last occurrence - Add mock Google Sheets API server and sync engine tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveArticle/saveArticlesnow check for existing URLs before writing, preventing duplicate rows when multiple devices save the same articlebatchUpdateArticlesre-fetches row numbers right before writing, avoiding stale indices caused by concurrent sheet modifications from other devicesgetArticlesdeduplicates by URL (keeps last occurrence), handling pre-existing duplicates gracefully