fix: typo and align remove-contact response with API#861
Open
Shubhdeep12 wants to merge 1 commit intoresend:canaryfrom
Open
fix: typo and align remove-contact response with API#861Shubhdeep12 wants to merge 1 commit intoresend:canaryfrom
Shubhdeep12 wants to merge 1 commit intoresend:canaryfrom
Conversation
…normalization function - Changed the response structure for the remove contact functionality to use `id` instead of `contact` for better clarity. - Introduced a normalization function to ensure backward compatibility by mapping `id` to `contact` in the response. - Updated tests to reflect the new response structure and ensure proper functionality.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idto match API; keepcontactas deprecated alias. we can start usingidin the new code andcontactwe can remove in the next major.reference: https://github.com/resend/resend-openapi/blob/main/resend.yaml
Summary by cubic
Aligns remove-contact response with the API by returning id and keeping contact as a deprecated alias for backward compatibility. Also fixes a parameter typo in contacts.create and updates topics tests to match API field names.
Bug Fixes
Migration
Written for commit d818bab. Summary will update on new commits.