Merged
Conversation
See issue #289 for details.
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Mar 14, 2026 4:44p.m. | Review ↗ |
| Shell | |
Mar 14, 2026 4:44p.m. | Review ↗ |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a deadlock in internal/stream.Channel when requeuePendingMsgs is invoked from sender() after a failed stream.Send while sendQ is unbuffered (default), by avoiding a self-blocking enqueue on the same queue the sender is responsible for draining.
Changes:
- Prevents
sender()from deadlocking itself by performing the requeue-enqueue loop asynchronously. - Preserves existing behavior of cancelling streaming (non-retriable) pending requests with
ErrStreamDown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289