added note to redis limits #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacy-qqq
requested review from
a team,
DanielAnderson,
ben-harris-5 and
logan
Clarified storage limit information for Redis usage.
Removed redundant note about exceeding storage limit and consolidated advice on staying under the limit.
ben-harris-5
approved these changes
Feb 11, 2026
Comment on lines
+29
to
+34
| If your app exceeds 500 MB of storage, writes to Redis may fail, which can affect features that depend on cached or stored data. To stay under the limit: | ||
|
|
||
| - Evict data by removing keys you no longer need | ||
| - Use TTLs to set expirations for temporary or stale data | ||
| - Monitor your app's data usage and be selective about what you store | ||
|
|
Member
There was a problem hiding this comment.
I think this is the only "real" diff in the file, and the rest is just style tweaks?
Can we get some sort of style enforcement on this repo, and do one big "style tweaks only" PR to bring the whole repo up to code? It's really hard to read a PR with 300 lines of diff, when there's only 5 that are "real changes" :\
logan
approved these changes
Feb 11, 2026
|
|
||
| If your app exceeds 500 MB of storage, writes to Redis may fail, which can affect features that depend on cached or stored data. To stay under the limit: | ||
|
|
||
| - Evict data by removing keys you no longer need |
There was a problem hiding this comment.
How possible is this with our current architecture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks