Open
Conversation
daanlenaerts
commented
Jan 15, 2026
| if (!json.success) { | ||
| toast.error(stringifyActionFailure(json.errors)); | ||
| if (!json.success || !json.company) { | ||
| toast.error(stringifyActionFailure(!json.success ? json.errors : {})); |
| if (!json.success) { | ||
| throw new Error(stringifyActionFailure(json.errors)); | ||
| if (!json.success || !json.company) { | ||
| throw new Error(stringifyActionFailure(!json.success ? json.errors : {})); |
| @@ -0,0 +1,299 @@ | |||
| import { sendEmail } from "@core/lib/email"; | |||
Contributor
Author
There was a problem hiding this comment.
We should rewrite this. We can't afford code duplication in the sending hot path.
kobeindemans
force-pushed
the
feat-email-to-peppol-sending
branch
from
d573656 to
a02f610
Compare
daanlenaerts
commented
Jan 16, 2026
Contributor
Author
daanlenaerts
left a comment
daanlenaerts
left a comment
There was a problem hiding this comment.
I will still rewrite the sending over Peppol from email code, to avoid code duplication in the hot path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.