Vary accept header for markdown #8301
Open
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this site is deployed to Vercel then:
However, if you go to https://react.dev/reference/react and do:
And follow that with:
You'll see that both return markdown. The network tab shows that the latter is read from disk. Reloading the page fetches fresh. This PR fixes that edge case, but in general, I think it is a good idea to be explicit about the Accept header being part of the cache key.
Deployment with this addition: https://react-dev-plum.vercel.app/learn - compare to what happens on react.dev
@rickhanlonii 🙏