Upgrade to Java 25, modernize build/CI, and refactor dynamic compiler internals#3
Draft
Upgrade to Java 25, modernize build/CI, and refactor dynamic compiler internals#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
/.github/workflows/feature-branches.ymland updated/.github/workflows/master.ymlto useactions/checkout@v4,actions/setup-java@v4with JDK25, and runmvn -B test; addedcontents: readpermissions.pom.xmlto setmaven.compiler.releaseto25, consolidate tojunit-jupiterwith propertyjunit.jupiter.version, upgradedmaven-compiler-pluginto3.14.1andmaven-surefire-pluginto3.5.4.final, replacedHashMapwithConcurrentHashMapinDynamicClassLoader, removed debugprintln, simplified and clarified method signatures, and replaced deprecated/fragile calls (e.g.Class#newInstance) withgetDeclaredConstructor().newInstance().IllegalArgumentExceptionfor bad URIs, usedList.of/List.copyOffor diagnostics, improvedgetDiagnosticsErrorformatting, usedFiles.readStringin test utilities, and small naming/signature cleanups (e.g. parameter renames and null-safety checks).assertThrows, descriptive test names), simplifiedCompilerExecutorandCompilerTestUtils, and adjusted test inputs/fixtures accordingly.README.mdto mention Java 25 and to modernize example usage.Testing
mvn -B test(JUnit Jupiter) against the updated project and the unit test suite completed successfully.mvn -B teston feature branch pushes and PRs tomaster(configured in the new/updated workflow files).